324690 - Need to ship vc8 redist bits in the installer

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P1)

Description

[Stuart Parmenter]

We need to bundle the vc8 redist bits.

either:
	msvcm80.dll
	msvcp80.dll
	msvcr80.dll
	Microsoft.VC80.CRT.manifest
("You may also redistribute all the files (*.dll and *.manifest) within a folder, listed below the folder for your convenience, as an entire set.")

or vcredist_x86.exe (need to make sure it doesn't put up any UI or anything)

Comment 1

[Benjamin Smedberg]

Attachment: Ship MSVC8 runtime libs in dist/bin, rev. 1

Comment 2

[Benjamin Smedberg]

Comment on attachment 210384 [details] [diff] [review]
Ship MSVC8 runtime libs in dist/bin, rev. 1

Paul, I added configure substitutions for MOZILLA_OFFICIAL, BUILD_OFFICIAL, and MOZ_MILESTONE_RELEASE as we discussed on IRC, so that they can be set in mozconfig and not need to be set in the tinderbox environment.

Comment 3

[J. Paul Reed [:preed]]

Comment on attachment 210384 [details] [diff] [review]
Ship MSVC8 runtime libs in dist/bin, rev. 1

Looks good!

Comment 4

[Benjamin Smedberg]

I'll take that as r=preed, fixed on trunk. Paul, you probably want to mark the review to get it out of your queue.

Comment 5

[J. Paul Reed [:preed]]

Comment on attachment 210384 [details] [diff] [review]
Ship MSVC8 runtime libs in dist/bin, rev. 1

I'll remember all the details one of these days...

Comment 6

[Frank Wein [:mcsmurf]]

Might it be this patch caused MOZILLA_OFFICIAL and/or BUILD_OFFICIAL to be enabled by default if it is not set? I build SeaMonkey on Windows with current Cygwin perl and now i have a Build ID: 2006020617 in the title bar (normally this was always 00000000).

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: quote-win32-redist-dir.patch

There's some funky quoting going on; to get the right things to happen in the makefile $(addprefix), the var needs to be stored with \ quotes around the spaces.  But that doesn't work for configure, so we have configure do the quoting.

Comment 8

[Benjamin Smedberg]

Comment on attachment 211044 [details] [diff] [review]
quote-win32-redist-dir.patch

Just put the |sed bits directly on WIN32_REDIST_DIR and don't bother with the _QUOTED variety.

Comment 9

[Frank Wein [:mcsmurf]]

Attachment: Fixes MOZILLA_OFFICIAL issue (see Comment 6)

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #9)
> Created an attachment (id=211167) [edit]
> Fixes MOZILLA_OFFICIAL issue (see Comment 6)

checked in
Checking in config/Makefile.in;
/cvsroot/mozilla/config/Makefile.in,v  <--  Makefile.in
new revision: 3.124; previous revision: 3.123
done