325223 - Remove close buttons or add them to windows which don't have them, to be consistent

Status: RESOLVED INCOMPLETE

(Firefox :: General, defect)

Description

[Andrés Delfino]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5

For example, a download item window has a Close button, but an image properties windows doesn't. I suggest to choose a way to present a consistent UI.

Reproducible: Always

Steps to Reproduce:

Actual Results:  
There should be a common way to close a window which is only used to show data.

Expected Results:  
There are, at least, two ways to close a window which is only used to show data.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
I see a close button on the titlebar of the Element Properties Window.

Comment 2

[Andrés Delfino]

(In reply to comment #1)
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111
> Firefox/1.5
> I see a close button on the titlebar of the Element Properties Window.
> 

Yes, *in the titlebar*. But, the window of a download item has to buttons, that titlebar button, and another one. That's what I'm talking about.

Comment 3

[Nickolay_Ponomarev]

There's a related bug that asks to be consistent as to whether a window can be dismissed using ESC/CTRL+W or no.

Comment 4

[Andrés Delfino]

I'd want to change this but to be:
Remove close buttons in windows

But I think I shouldn't change the meaning of a bug after it was classified as NEW. The problem is that the current meaning is ambivalent and does not propose something specific. My initial intention was to remove close buttons in windows, but I proposed a consistent way, whichever it was, instead.

Could someone please mark this as UNCONFIRMED so I can change the summary, please?

Comment 5

[Peter van der Woude [:Peter6]]

what summary ?
I'll edit it for you

Comment 6

[Andrés Delfino]

(In reply to comment #5)
> what summary ?
> I'll edit it for you
> 

Proposed summary:
Remove close buttons from windows

Actual meaning (you may have a better summary for the idea):
Remove close buttons from windows, since the titlebar already provides a way of closing windows. Only buttons with label "Close" are considered here.

For instance, compare an image properties window and any exceptions window (say, Allowed Sites - Pop-ups).

Comment 7

[Peter van der Woude [:Peter6]]

You mean:
"use the [X] button to close UI and not a [Close](=text) button"

[X] for Windows/Linux and one of the colored [0] for Mac

Comment 8

[Andrés Delfino]

(In reply to comment #7)
> You mean:
> "use the [X] button to close UI and not a [Close](=text) button"
> 
> [X] for Windows/Linux and one of the colored [0] for Mac
> 

Now I don't know if I completely understand what you are saying :P

What I'm saying is that providing a button with no function other than closing a window: a) adds nothing but a button that does what most (if not all) window managers already provide a way to do (most of them already provide a _button_ for doing it), and b) is not our job, the window _manager_ used by the user is what _manages_ the windows.

Comment 9

[Peter van der Woude [:Peter6]]

after re-reading all posts I still don't get it.

As far as I can see all UI windows have an [X] in the titlebar to close it, which is consitent with all Windows apps that I know of.

Only the "pop-up manager" and "block images from websites manager" have an additional [Close] button in the bottom right which does not make any sense to me.

Comment 10

[Andrés Delfino]

(In reply to comment #9)
> after re-reading all posts I still don't get it.
> 
> As far as I can see all UI windows have an [X] in the titlebar to close it,
> which is consitent with all Windows apps that I know of.
> 
> Only the "pop-up manager" and "block images from websites manager" have an
> additional [Close] button in the bottom right which does not make any sense to
> me.
> 

Preferences window also has a close button. Sadly, I can't grep the sources to get all instances, giving that the code is broken in different lines.

Comment 11

[Andrés Delfino]

It makes the Exceptions - Saved Passwords and Saved Passwords windows look awful.

Comment 12

[Wayne Mery (:wsmwk)]

since no one understands this -> incomplete