Closed Bug 32523 Opened 24 years ago Closed 24 years ago

nsDocLoader broken on ALL 64 bit platforms.

Categories

(Core :: Networking, defect, P3)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: msw, Assigned: ftang)

Details

nsDocLoader.cpp line 317:

nsDocLoaderImpl::GetContentViewerContainer(PRUint32 aDocumentID,
                                           nsIContentViewerContainer** aResult)
{
  nsISupports* base = (nsISupports*) aDocumentID;
  nsIDocument* doc;
  nsresult rv;

  rv = base->QueryInterface(kIDocumentIID, (void**)&doc);

----

You've just loaded a 32 bit value into a pointer and tried to dereference it. 
This breaks on 64 bit platforms including Compaq Alpha, UltraSPARC (if you're
building a 64 bit application), and ia64.
Summary: Doc Loader broken on ALL 64 bit platforms. → nsDocLoader broken on ALL 64 bit platforms.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Setting target milestone to M15 and accepting bug.
Status: NEW → ASSIGNED
Target Milestone: --- → M15
This got fixed by Frank Tang before I could get to it.  Re-assigning to Frank 
so that he can mark it fixed.
Assignee: nisheeth → ftang
Status: ASSIGNED → NEW
(from netherlands... ) this code have been fixed. Harishd need to change the 
part which cast void* into PRInt32 in parser to make it really work.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
What's the bug on the parser so that we can track that?
not fixed until
http://lxr.mozilla.org/seamonkey/search?string=%28nsISupports*%29aDocumentID
is clean
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
reassigning to myself. Have the change in hand...will land soon.
Assignee: ftang → harishd
Status: REOPENED → NEW
Okay, my part is done...  Back to ftang to verification. 

Note: verify with Apr 5th build.
Assignee: harishd → ftang
It should be fixed now.
Status: NEW → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
Verified fixed here.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.