32536 - text gets wrong font size

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[juberti]

When diffing using Bonsai at AOL or at mozilla.org I get extra linefeeds. I
don't see this with IE5 or NS 4.7. See
http://cmihoss.office.aol.com:2000/client/bonsai/cvsview2.cgi?command=DIFF&subdir=cool%2FInclude&file=CoolVersion.h&rev1=1.15&rev2=1.16&whitespace_mode=show&diff_mode=context
for an example.

I saw this in the 3-16-b1 windows build.

Comment 1

[Kathleen :Brade]

sounds like a layout issue; not an editor issue

Comment 2

[troy]

Line layout issue

Comment 3

[Asa Dotzler [:asa]]

confirming

Comment 4

[buster]

could you please attach a test case that is publically accessable?  you could
either save the html to disk then upload it using the bugzilla form, or point to
a bonsai page off of mozilla.org that shows the problem.  Thanks!

Comment 5

[juberti]

Attachment: Example of problem

Comment 6

[juberti]

Seems the LF problem is fixed, but now the type size is too big compared to 
4.7, so the diffs don't fit in the browser window.

Comment 7

[buster]

looks like this might be a style resolution or font mapping problem.  assigning
to marc so he can validate we're getting the right style, cc-ing erik in case
it's font mapping.

Comment 8

[Marc Attinasi]

We are getting the correct font sizes in the Style Context, as show by dumping
the style context data from Viewer.

Additionally, the font size for the Lucida Console font, sized at -1 looks to me
to be the same as that of Nav4. In fact, I've created a testcase with that face
in sizes from -5..5 and they look pretty much the same as Nav4.

Is this really a bug? When I laod the attachment in NS6 (buildID 200092808) and
Nav4 and compare them, each visible line is showing up to the same character...

Closing as WORKSFORME - if I am missing something here, please re-open and
explain how the font size is wrong (a picture would be great too). Thanks.

Comment 9

[Marc Attinasi]

Attachment: Testcase showing various font sizes for comparison w/ Nav4

Comment 10

[Marc Attinasi]

Reopening: Buster just showed me how his machine shows the page, and the
testcase I attached, and I see that it different. On my machine, using a NS6
build from yesterday, the font sizes look the same. Using a tip-of-branch build
from today, the font sizes *are* different...

Over to Erik: did something change in font sizing in the last day? size=0 and
size=-1 look different sizes, and size=4 has different weight. I'll attach
screen shots to show the differences.

Comment 11

[Marc Attinasi]

Attachment: screenshot of NS6 (0928), Mozilla (0929) and Nav4.7 renderings of the testcase: fonts sizes differ

Comment 12

[Marc Attinasi]

Sending to Erik - the font size mappings seem to have changed (in the last day
even). Can you make it out?

(Also, I updated the URL to the public page)

Comment 13

[Erik van der Poel]

Attachment: better test case, showing size=-1, size=+1, size=1, etc.

Comment 14

[Erik van der Poel]

I don't know of any recent changes in the <font size=-1> code. Pierre, do you
know of any? Could it be related to some changes in the strict vs compat mode?
If I recall correctly, the font sizing depends on that mode.

Comment 15

[Pierre Saslawsky]

I can't explain why N6 and Moz differ, but there is a logical explication about 
why <font size-0> isn't the same as Nav4 (default prefs, I think).

Marc: Size 4 doesn't have a different weight. The Moz sizes (except for 0) are 
all one step smaller than the N6 sizes.

Comment 16

[Hixie (not reading bugmail)]

Upon managerial request, adding the "testcase" keyword to 84 open layout bugs that
do not have the "testcase" keyword and yet have an attachement with the word
"test" in the description field. Apologies for any mistakes.

Comment 17

[karnaze (gone)]

Moving to m1.0

Comment 18

[Asa Dotzler [:asa]]

Is this still a useful report? If it is can someone please remove the Netscape
Confidential flag or if there is real proprietary info I'll be glad to file a
clean version so we can resolve this Netscape Confidential bug as invalid. 

Comment 19

[juberti]

Removing Netscape confidential. The problem is demonstrated by the attachments 
and so the original AOL internal URL is not needed. Also, I am no longer seeing 
the extra linefeeds in Moz 0.8, but the different text size issue remains.

Comment 20

[rbs]

Looks like this a dup with bug 72164 -- the font-size mapping code in
nsStyleUtil.cpp needs to be revisited.

Comment 21

[rbs]

Should be fixed as part of my font changes in bug 99010.
pierre, you might to check if things are okay with you.

Comment 22

[rbs]

Marking as FIXED now.

Comment 23

[Chris Petersen]

Marking verified in the Oct 22nd build.