Closed Bug 325429 Opened 19 years ago Closed 16 years ago

My own address should be removed from Mail-Followup-To: on reply

Categories

(MailNews Core :: Backend, defect)

Product:
MailNews Core
Component:
Backend
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.0b1

People

(Reporter: pierre-bugzilla, Assigned: mail)

References

(
URL
)

Details

(Whiteboard: [real request in comment 1] [has patch])

Attachments

(1 file, 1 obsolete file)

bugfix v1.0.1
1.25 KB, patch
Bienvenu
: superreview+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.8) Gecko/20060126 Fedora/1.5-5 Firefox/1.5
Build Identifier: version 1.6a1 (20060131)

When the header 'Sender:' is set thunderbirds puts my own email address in To:, not the one in From:.

I.e.

From: john@doe.com
Sender: john@doe.com
To: me@example.com

*reply*

From: me@example.com
To: me@example.com


Reproducible: Always

Steps to Reproduce:
Sorry, false alarm. The mails in question also have a Mail-Followup-To: header, causing said behaviour.

So instead I have another bug report/feature request: Filter my own address from the Mail-Followup-To: list. (the same way it's filtered from the To:s and Cc:s).
Severity: major → normal
Summary: Replying when Sender: is set causes invalid To: → My own address should be removed from Mail-Followup-To:
QA Contact: message-compose
Yes, the code that filters own address is applied to the new message's Cc header only, but the Mail-Followup-To addresses are put into the new To header.  I'm preparing a patch...
Attached patch [patch] bugfix (obsolete) — — Splinter Review 
attached patch fixes this issue
Attachment #328169 - Flags: review?(mscott)
Assignee: mscott → mail
URL: http://cr.yp.to/proto/replyto.html
Status: UNCONFIRMED → NEW
Component: Message Compose Window → MailNews: Backend
Ever confirmed: true
OS: Linux → All
Product: Thunderbird → Core
QA Contact: message-compose → backend
Hardware: PC → All
Summary: My own address should be removed from Mail-Followup-To: → My own address should be removed from Mail-Followup-To: on reply
Whiteboard: [real request in comment 1] [has patch]
Attachment #328169 - Flags: review?(mscott) → review?(dmose)
Product: Core → MailNews Core
Comment on attachment 328169 [details] [diff] [review]
[patch] bugfix

+              if (type == nsIMsgCompType::ReplyAll && ! mailFollowupTo.IsEmpty())

nit: drop the space after the !

r=me with that fixed.

Would you consider doing unit tests for this bug as well?
Attachment #328169 - Flags: superreview?(bienvenu)
Attachment #328169 - Flags: review?(dmose)
Attachment #328169 - Flags: review+
Flags: in-testsuite?
Attached patch bugfix v1.0.1 — — Splinter Review 
Should conform to Mozilla coding style now.
Attachment #328169 - Attachment is obsolete: true
Attachment #343892 - Flags: superreview?
Attachment #328169 - Flags: superreview?(bienvenu)
Comment on attachment 343892 [details] [diff] [review]
bugfix v1.0.1

Daniel, you either missed adding the email address for David when requesting review or got it wrong - I've fixed it for you.
Attachment #343892 - Flags: superreview? → superreview?(bienvenu)
Comment on attachment 343892 [details] [diff] [review]
bugfix v1.0.1

We're dropping the rv of RemoveDuplicateAddresses, but that's OK...thx for the patch.
Attachment #343892 - Flags: superreview?(bienvenu) → superreview+
Checked in, changeset id 648:8d3721ac95ed
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b1
This FIXED bug is flagged with in‑testsuite?   It would be great if assignee or someone else can clear the flag if a test is not appropriate.  And if appropriate, create a test and plus the flag to finish off the bug.
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: