325762 - Recurrence dialog ignores recurrence units

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Stephan Schaefer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5

The recurrence units (repeat for n days/weeks/months) are not respected. As there is no useful internal represenation possible for the unit it should just read 'occurences'.

Reproducible: Always

Steps to Reproduce:
1. Create a weekly recurring event
2. Let it repeat for 2 month
3. 

Actual Results:  
It is repeated only twice.

Expected Results:  
Repeated 8 times.

Comment 1

[Stephan Schaefer]

Attachment: Removes recurrence units menu.

As it is quite difficult to properly restore the unit upon editing the recurrence rule it should always be treated as a plain count. The patch removes the units menu and replaces it with a simple label:
Repeat for: n occurrence(s)

Comment 2

[Joey Minta]

Comment on attachment 210611 [details] [diff] [review]
Removes recurrence units menu.

It was a mildly interesting concept to have units there, but this seems much simpler/better.  Nice work. r=jminta

Comment 3

[Joey Minta]

Patch checked in. :-)