Closed
Bug 325763
Opened 19 years ago
Closed 19 years ago
Remove calls to IsVoid
Categories
(Firefox :: Bookmarks & History, defect, P4)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 2 beta1
People
(Reporter: brettw, Assigned: brettw)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file, 1 obsolete file)
|
3.75 KB,
patch
|
Details | Diff | Splinter Review |
When bug 324994 is done, storage will call SetIsVoid on null strings so we won't have to. Remove the checks in places for this.
|
Assignee | |
Updated•19 years ago
|
Severity: normal → trivial
Priority: -- → P4
Target Milestone: --- → Firefox 2 beta1
|
|
Assignee | |
Comment 1•19 years ago
|
||
Now that the storage service sets IsVoid when the column is NULL, we can remove our checks.
Attachment #211068 -
Flags: review?(annie.sullivan)
|
||
Updated•19 years ago
|
Attachment #211068 -
Flags: review?(annie.sullivan) → review+
|
|
Assignee | |
Comment 2•19 years ago
|
||
In testing this it seems sqlite treats empty strings the same as NULLs so this doesn't do what we want. Instead, we should have another method for differentiating unset user titles from set empty user titles.
Severity: trivial → minor
Summary: Remove calls to SetIsVoid → Support empty user titles (differentiatable from unset)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #211068 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•19 years ago
|
||
My previous tests were wrong, null and empty string are distinct
Summary: Support empty user titles (differentiatable from unset) → Remove calls to IsVoid
|
|
Assignee | |
Comment 4•19 years ago
|
||
This patch is the uploaded one. It fixes a one-line problem where void strings are not handled properly in row reading.
|
|
Assignee | |
Comment 5•19 years ago
|
||
On branch and trunk
|
||
Comment 6•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•