Closed Bug 325845 Opened 19 years ago Closed 18 years ago

Esc should cancel incomplete edit, not commit it, when closing Bookmark Info panel

Categories

(Camino Graveyard :: Bookmarks, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Camino1.5

People

(Reporter: alqahira, Assigned: froodian)

References

Details

(Keywords: fixed1.8.1.1)

Attachments

(1 file)

In the bookmark info panel, Esc currently commits an in-progress edit and closes the info panel.  Instead, Esc should cancel the in-progress (uncommitted) edit when it closes the panel.
This panel has accumulated a list of bugs; see also bug 319746 and the depends list of bug 325880.
Assignee: mikepinkerton → nobody
OS: Mac OS X 10.2 → Mac OS X 10.3
QA Contact: bookmarks
Summary: Esc should cancel incomplete edit, not commit it, when closing Info panel → Esc should cancel incomplete edit, not commit it, when closing Bookmark Info panel
Depends on: 337570
Assignee: nobody → stridey
Attached patch PatchSplinter Review
Attachment #244548 - Flags: review?(mozilla)
Comment on attachment 244548 [details] [diff] [review]
Patch

r=me, code-wise
Attachment #244548 - Flags: review?(mozilla) → review+
Attachment #244548 - Flags: superreview?(stuart.morgan)
Comment on attachment 244548 [details] [diff] [review]
Patch

>+  // update UI so changes don't get committed

s/update/revert/

sr=smorgan with that change
Attachment #244548 - Flags: superreview?(stuart.morgan) → superreview+
Depends on: 360345
Checked in on trunk and 1.8branch
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: