325873 - [10.4] Camino should set the kMDItemWhereFroms attribute on downloaded files

Status: RESOLVED FIXED

(Camino Graveyard :: Downloading, enhancement)

Description

[Anders Conradi]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051229 Camino/1.0b2
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051229 Camino/1.0b2

When Camino downloads a file to disk on Mac OSX Tiger it should set the kMDItemWhereFroms attribute on the file to the url the file was downloaded from in the same way as Safari does it.

Reproducible: Always

Steps to Reproduce:
1. Download a file
2. Reveal the file in the finder
3. Right click on the file and select Get Info
4. In the More Info part of the window there should be a field called Where From: containing the url the file was downloaded from. Now there isn't

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

See also bug 90918 comment 130.

Torben/Kreeger, this would have to be done in Core, right (as opposed to comments which we can sort-of do in Camino without Core support)?

Comment 2

[Chris Lawson (gone)]

We can add this before we drop 10.3 support, but adding the [10.4] tag to indicate this is a 10.4-only feature.

FWIW, this doesn't seem like it would necessarily require Core changes, but if we can get Core to do the Right Thing(tm), it's probably better.

cl

Comment 3

[Chris Lawson (gone)]

Oh yeah. Confirming.

Comment 4

[Torben]

The main problem is that there is no Apple-supported way of doing this, ATM an app can only set metadata for file it owns (which won't be the case for most downloads).

As soon as such a method exists, it could be called either from Camino-code (but will not work for drag-and-drop saves) or from gecko (like bug 154580 and bug 90918).

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Note that unlike Finder/"Spotlight" Comments (bug 154580 and
bug 90918), the kMDItemWhereFroms metadata is not preserved on certain types of copies.

This may be a good thing or a bad thing depending on your perspective (especially since the user has no way of modifying/removing them); Comments, OTOH, are preserved, but the user also has a way to remove them ;)

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 357219 has been marked as a duplicate of this bug. ***

Comment 7

[Mark Mentovai]

Proof-of-concept at bug 337051 attachment 292163 [details] [diff] [review]

Comment 8

[Mark Mentovai]

Why does Bugzilla let you assign bugs to nobody?

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #8)
> Why does Bugzilla let you assign bugs to nobody?

Because bmo is still using a version of Bugzilla without the fix for bug 92552?

Comment 10

[Mark Mentovai]

Attachment: Use undocumented MDItemSetAttribute (trunk)

Comment 11

[Mark Mentovai]

Attachment: With extra symbol-lookup stuff for 10.3 compatibility (1.8 branch)

Comment 12

[Stuart Morgan]

Comment on attachment 293133 [details] [diff] [review]
Use undocumented MDItemSetAttribute (trunk)

>+  if (mReferrer) {
>+    if (NS_SUCCEEDED(mReferrer->GetSpec(url))) {

I can has && ?

Comment 13

[Mark Mentovai]

Comment on attachment 293133 [details] [diff] [review]
Use undocumented MDItemSetAttribute (trunk)

Stuart, you sure can.

Comment 14

[Mark Mentovai]

I just crashed in SetMetadata in a really small download.  Looking...

Comment 15

[Mark Mentovai]

Attachment: Use undocumented MDItemSetAttribute (trunk, v2)

The crash occurred when downloading something by option-click or a contextual menu's "Download Link Target…".  Those downloads come through SaveHeaderSniffer, and we had mTempFile null.  I hadn't counted on that, but you can certainly see how it might crash.

Incidentally, it affected the quarantine too, although the quarantine would fail silently when mTempFile was null.  That problem is addressed in this version.  So is Stuart's cat's request for &&.

Comment 16

[Mark Mentovai]

Attachment: With extra symbol-lookup stuff for 10.3 compatibility (1.8 branch, v2)

Comment 17

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 293225 [details] [diff] [review]
Use undocumented MDItemSetAttribute (trunk, v2)

sr=pink

Comment 18

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 293226 [details] [diff] [review]
With extra symbol-lookup stuff for 10.3 compatibility (1.8 branch, v2)

sr=pink

Comment 19

[Mark Mentovai]

Checked in on the trunk and MOZILLA_1_8_BRANCH before 1.6b1.