Closed Bug 325901 Opened 19 years ago Closed 12 years ago

Some files are preprocessed unnecessarily

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 17

People

(Reporter: Gavin, Assigned: andreshm)

References

Details

Attachments

(1 file, 6 obsolete files)

rolled up browser/ patch
105.06 KB, patch
Gavin
: review+
Details | Diff | Splinter Review 
This increases build time and should be fixed. I'll do CSS files first, since they're blocking the branch patch for bug 305767.
Status: NEW → ASSIGNED
Attached patch CSS files (checked in) (obsolete) — — Splinter Review 

        Attachment #210706 -
        Flags: review?(mconnor)
Whiteboard: [patch-r?]

        Attachment #210706 -
        Flags: review?(mconnor)

        Attachment #210706 -
        Flags: review+

        Attachment #210706 -
        Flags: approval-branch-1.8.1+
Target Milestone: Firefox 2 alpha1 → Firefox 2

    
    

    
  
Comment on attachment 210706 [details] [diff] [review]
CSS files (checked in)

checked in, branch and trunk. leaving open for other possible files.

        Attachment #210706 -
        Attachment description: CSS files → CSS files (checked in)
Priority: -- → P5
Target Milestone: Firefox 2 → ---
Whiteboard: [patch-r?]
Target Milestone: --- → Future
Assignee: gavin.sharp → nobody
Status: ASSIGNED → NEW
Priority: P5 → --
Target Milestone: Future → ---

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix files in browser/base (obsolete)
        — 
          — Splinter Review
      

    


  
I did a quick pass and tried to fix the files in browser/base. I haven't looked over this carefully, it may have bugs.

        Attachment #210706 -
        Attachment is obsolete: true

    
    

    
  
I'll continue with this.
Assignee: nobody → andres

    
  
Status: NEW → ASSIGNED

    
    

    
  
Question, the %if 0 or #if 0 directives are required for some reason or can be removed?

    
    

    
  
It depends on the specific use. But I don't think you should worry about those to start - let's just get the ones that the preprocessor warns about to begin with.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v1 browser/base (obsolete)
        — 
          — Splinter Review
      

    


  
browser/base fixes.

        Attachment #644063 -
        Attachment is obsolete: true

        Attachment #651450 -
        Flags: review?(gavin.sharp)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v1 browser/components (obsolete)
        — 
          — Splinter Review
      

    


  
browser/components fixes.

        Attachment #651451 -
        Flags: review?(gavin.sharp)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v1 browser/locales (obsolete)
        — 
          — Splinter Review
      

    


  
browser/locales fixes.

        Attachment #651452 -
        Flags: review?(gavin.sharp)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v1 browser/themes (obsolete)
        — 
          — Splinter Review
      

    


  
browser/themes fixes.

        Attachment #651453 -
        Flags: review?(gavin.sharp)

    
    

    
  
I'll continue with toolkit files

    
    

    
  
Toolkit files are fine. Any other I should check?

    
    

    
  
We want to fix all the warnings that show up during a mozilla-central firefox build, but I imagine there may be a long tail. Don't need to tackle that in this bug, might be good to file a followup.

        Attachment #651450 -
        Flags: review?(gavin.sharp) → review+

        Attachment #651451 -
        Flags: review?(gavin.sharp) → review+

        Attachment #651452 -
        Flags: review?(gavin.sharp) → review+

        Attachment #651453 -
        Flags: review?(gavin.sharp) → review+

    
    

    
  


  
Thanks for fixing this, Andres!

        Attachment #651450 -
        Attachment is obsolete: true

        Attachment #651451 -
        Attachment is obsolete: true

        Attachment #651452 -
        Attachment is obsolete: true

        Attachment #651453 -
        Attachment is obsolete: true

        Attachment #651795 -
        Flags: review+

    
    

    
  
Thank you, do we need a try run for this?

    
    

    
  
Nope! :)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/6d0ce062c403
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: