325913 - Allow search plugins to have a "search page" URL for blank searches

Status: RESOLVED FIXED

(Firefox :: Search, enhancement, P3)

Description

[JConley]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1

I often use keyword searches (currently keyword bookmarks) with and without the %s parameter substitution.

Would be nice if future keyword searching could use a different url for non-parameter requests vs those with a parameter request.

For example:
'bug' would use url 'http://bugzilla.mozilla.org'
'bug 317107' would use url 'https://bugzilla.mozilla.org/show_bug.cgi?id=%s'

'g' would use url 'http://www.google.com'
'g keyword' would use 'http://www.google.com/search?q=%s&hl=en'


Reproducible: Always

Comment 1

[JConley]

In the meantime I found a way to hack this in 1.5 using bookmark javascript:
javascript:(function(){document.location=('%s'!='\%\s'?'http://www.google.com/search?q=%s&hl=en':'http://www.google.com');})();

Comment 2

[zug_treno]

Related to bug 298697?

Comment 3

[JConley]

No, not related. 298697 says %s is not replaced with empty string when no parameter is specified.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Sherlock plugin description files can specify a "searchForm" attribute (http://mycroft.mozdev.org/deepdocs/searchtag.html#searchForm), I couldn't find an equivalent OpenSearch attribute but I'll look into it further. This attribute will be used when pressing enter in the search bar with no search terms. Plugins that don't specify an alternate searchForm will likely use just the host of the query URL (i.e. google.com for google.com/?q=foo). I'm still not how bookmark keywords and the search service will interact - I'm thinking that maybe what is now known as "bookmark keywords" will become "search engines" that appear in the management UI but not in the toolbar.

Comment 5

[Mike Connor [:mconnor]]

This is ripe for cutting right now.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: add searchForms to existing plugins

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 219837 [details] [diff] [review]
add searchForms to existing plugins

>   get searchForm() {
>-    // XXX OpenSearch has a searchForm attribute, should use it instead of this
>-    // ugly ugly hack
>+    if (this._searchForm)
>+      return this._searchForm;
>+    // XXX hack
>     return makeURI("http://" + makeURI(this._urls[0].template).host).spec;
>   },

can you add a more expansive comment explaining what we're doing here (going to the domain root for the searchplugin)

Comment 8

[Jesse Ruderman]

>     return makeURI("http://" + makeURI(this._urls[0].template).host).spec;

Why always http?  Why not use the protocol specified along with the hostname?

Comment 9

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #8)
> >     return makeURI("http://" + makeURI(this._urls[0].template).host).spec;
> 
> Why always http?  Why not use the protocol specified along with the hostname?

No good reason, I'll make that change.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Attachment: better patch

- Use Jesse's suggestion from comment 8
- Fix searchForm get as discussed on IRC
- make it return the searchForm when submitting a blank query, too

Comment 11

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #10)
> - Use Jesse's suggestion from comment 8
> - Fix searchForm get as discussed on IRC
> - make it return the searchForm when submitting a blank query, too

Also: changed the parse* functions to sync with changes from bug 335472.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Checked in attachment 223862 [details] [diff] [review], branch and trunk.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Hrm, I really didn't fix this bug as summarized - the plan was to have search plugins be the backend for keyword search, but that didn't happen. Bug 306221 covers the original intent of this bug, though, so I'm going to fully morph this one.

Comment 14

[:Gavin Sharp [email: [e-mail]]]

*** Bug 322934 has been marked as a duplicate of this bug. ***