326174 - nsICookieService should provide getCookie, a method that returns a nsICookie

Status: RESOLVED FIXED

(Core :: Networking: Cookies, enhancement)

Description

[Jason Barnabe (np)]

nsICookieService provides, among other things, getCookieString and getCookieStringFromHttp. They provide a cookie string that has to be parsed to be useful. This interface would be much more useful if it had methods that returned nsICookies.

Comment 1

[[e-mail]]

have you looked at nsICookieManager/nsICookieManager2? please elaborate on why you think this is a good idea.

Comment 2

[Jason Barnabe (np)]

nsICookieManager makes you enumerate through every cookie to find what you want. nsICookieManager2 has nothing comparable.

It's a good idea because it would make that interface actually useful. If I want to read a cookie's value, right now I either have to enumerate through every cookie with nsICookieManager or get the cookie string and then implement cookie parsing logic. There's currently no interface that I know of to go from a cookie string to a nsICookie.

(It doesn't matter to me whether it goes in nsICookieManager or nsICookieService.)

Comment 3

[Darin Fisher]

What about nsICookieServiceInternal::getCookieValue?

Comment 4

[Darin Fisher]

Nevermind.  That API doesn't seem to do what you want either.

Comment 5

[[e-mail]]

-> me, seems like a good idea.

Comment 6

[[e-mail]]

this will be fixed by the patch in bug 423132.

Comment 7

[[e-mail]]

Reassigning to nobody. If anyone wants to work on this, feel free!