326321 - Convert bookmark add/remove functionality to use controller.js

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Joe Hughes]

Currently, the bookmark add/remove functionality goes directly to the Bookmarks Service.  In order to make these actions undoable, they should go through the controller.js interface in Places.

Comment 1

[Joe Hughes]

Attachment: Moves transactions to a separate file and converts bookmark properties dialog actions (except change URI) to use transaction manager

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Approach looks OK So far...

Comment 3

[Joe Hughes]

Attachment: Updated version of previous patch (some updates; also dispenses with transactions.js)

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 216790 [details] [diff] [review]
Updated version of previous patch (some updates; also dispenses with transactions.js)

sr=[e-mail]

Comment 5

[Joe Hughes]

Landed on branch & trunk.

Comment 6

[susanta]

this is a test

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv