326883 - Get rid of unused nsFormControlFrame methods

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Eli Friedman]

GetDesiredSize, GetWidgetSize, mWidgetSize, GetWidgetInitData, SetClickPoint, mLastClickPoint, GetScrollbarWidth, ControlChanged, and EnterPressed are unused; and probably HandleEvent is unneeded.

Also, the class declarations can go, and NS_FORMSIZE_NOTSET, and the includes for nsFormControlHelper.h, nsPresContext.h, nsIWidget.h, nsCOMPtr.h.

It seems like this stuff just collects.

Comment 1

[Eli Friedman]

The three-argument form of GetDesiredSize is used.

Comment 2

[Eli Friedman]

Attachment: Patch

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 211939 [details] [diff] [review]
Patch

yes, yes it does

Comment 4

[Eli Friedman]

Checked in.

Comment 5

[Bernd]

Oh, a dream comes true, removing the debug stuff from form controls will probably shrink the files by 1/3.

http://lxr.mozilla.org/seamonkey/search?string=REFLOW_DEBUG_MSG most of the reflow messages are anyway covered by the frame reflow debug mechanism (http://www.mozilla.org/newlayout/doc/frame_reflow_debug.html)