327065 - misc necko cleanup

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

I have some patches in my tree that fix some minor things in necko... I'll use this bug for all of them, they're not worth filing one bug for each.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: use the #define for the stringbundle URL

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: actually init xpcom

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: don't test isSuccessCode where it will always be a failure

(it's a failure because onStartRequest always throws here)

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: add a -pac argument to TestProtocols

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: misc cleanup

make stuff static, remove unused code, PRBool->PRPackedBool

Comment 6

[Darin Fisher]

Comment on attachment 211784 [details] [diff] [review]
misc cleanup

hmm... I'm not so sure it makes sense to prefer PRPackedBool over PRBool when there is only one PRBool.  all your doing is forcing the CPU to read/write a byte instead of a word, and it anyways fetches a word, so there isn't much benefit to this.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in, except that PRPackedBool change

Checking in netwerk/base/src/nsAsyncStreamListener.cpp;
/cvsroot/mozilla/netwerk/base/src/nsAsyncStreamListener.cpp,v  <--  nsAsyncStreamListener.cpp
new revision: 1.49; previous revision: 1.48
done
Checking in netwerk/base/src/nsFileStreams.cpp;
/cvsroot/mozilla/netwerk/base/src/nsFileStreams.cpp,v  <--  nsFileStreams.cpp
new revision: 1.74; previous revision: 1.73
done
Checking in netwerk/base/src/nsLoadGroup.cpp;
/cvsroot/mozilla/netwerk/base/src/nsLoadGroup.cpp,v  <--  nsLoadGroup.cpp
new revision: 1.69; previous revision: 1.68
done
Checking in netwerk/streamconv/converters/nsIndexedToHTML.cpp;
/cvsroot/mozilla/netwerk/streamconv/converters/nsIndexedToHTML.cpp,v  <--  nsIndexedToHTML.cpp
new revision: 1.72; previous revision: 1.71
done
Checking in netwerk/test/TestOpen.cpp;
/cvsroot/mozilla/netwerk/test/TestOpen.cpp,v  <--  TestOpen.cpp
new revision: 1.8; previous revision: 1.7
done
Checking in netwerk/test/TestProtocols.cpp;
/cvsroot/mozilla/netwerk/test/TestProtocols.cpp,v  <--  TestProtocols.cpp
new revision: 1.113; previous revision: 1.112
done
Checking in netwerk/test/unit/test_cookie_header.js;
/cvsroot/mozilla/netwerk/test/unit/test_cookie_header.js,v  <--  test_cookie_header.js
new revision: 1.4; previous revision: 1.3
done