327188 - Enable places by default

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

Per the product team meeting today, we're going to enable places by default after the nightly builds have finished tomorrow morning (15-Feb).

Comment 1

[Benjamin Smedberg]

*** Bug 327196 has been marked as a duplicate of this bug. ***

Comment 2

[Benjamin Smedberg]

Attachment: Patch to be committed, rev. 1

This patch enables places by default for ffox/xulrunner, and fixes up toolkit/library and a few uses of LIBXUL_LIBRARY so that a places xulrunner builds correctly.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 211909 [details] [diff] [review]
Patch to be committed, rev. 1

I can sr, does someone like bryner need to r=?

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 211909 [details] [diff] [review]
Patch to be committed, rev. 1

not sure why storage has to move earlier in the build order, but r=me either way

Comment 5

[Benjamin Smedberg]

Fixed on trunk. I needed to move storage above libxul in order to link it into libxul.

Comment 6

[Benjamin Smedberg]

Attachment: 1.8 branch patch

Equivalent 1.8 branch patch

Comment 7

[Pavel Franc - Mozilla.cz]

Wouldn't this break the l10n builds?
See http://lxr.mozilla.org/mozilla/source/browser/components/places/locale/README

Comment 8

[Axel Hecht [:Pike]]

Yes, it does. It doesn't break the build, but the places stuff is hard-linked
into en-US.jar, which we remove during repackaging.
If you move stuff into browser/locales/, please be sure to use good paths in the
jar, namely jar:en-US.jar!/locale/en-US/browser/places

Comment 9

[Doug Shelton]

possible regression - BeOS builds broken in /storage.  Builds were OK <24 hours ago.

Comment 10

[Doug Shelton]

(In reply to comment #9)
> possible regression - BeOS builds broken in /storage.  Builds were OK <24 hours
> ago.
> 
Bug 327471 opened for regression.

Comment 11

[Boris Zbarsky [:bzbarsky]]

So... the tree's been closed for over 24 hours at this point due to this change.  Is there an ETA for when we think we'll reopen it (either by getting the fallout fixed or by reverting the configure change until the necessary followup patches land)?

Comment 12

[Brian Ryner (not reading)]

I turned off places in configure.in just now (not by reverting the whole patch above, just by commenting out the two occurances of MOZ_PLACES=1 in the application sections).  We're going to get a handle on the leaks etc. and then turn this back on hopefully next week.

Comment 13

[Benjamin Smedberg]

Matching changes checked in on the 1.8 branch, so this can be enabled on trunk and branch by simply un-commenting the # MOZ_PLACES=1 lines in configure.in

Comment 14

[Axel Hecht [:Pike]]

Note that the l10n part of this is not fixed yet AFAICT, that is, turning places 
on will break the l10n builds without showing that on the tinderboxens.

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

This seems to be enabled on trunk again - is that right?

Comment 16

[Brett Wilson]

It was re-enabled March 1 in the early evening US pacific time.

Comment 17

[Mike Schroepfer]

Should this be resolved fixed?

Comment 18

[Brett Wilson]

(In reply to comment #17)
> Should this be resolved fixed?

I think so.

Comment 19

[Ray Trent]

Sorry for the bugspam, but I've been looking around, and I can't find any place where people are having a discussion about whether this feature is:

a) The greatest thing since sliced bread.
or
b) An unusable poorly thought out broken wad of garbage. 

Is there such a forum?

I'm in the b) category myself, but I'd really like to hear some arguments from those in the a) camp to show me the one true way. 

Comment 20

[bugzilla]

(In reply to comment #19)
> Sorry for the bugspam, but I've been looking around, and I can't find any place
> where people are having a discussion about whether this feature is:
> 
> a) The greatest thing since sliced bread.
> or
> b) An unusable poorly thought out broken wad of garbage. 
> 
> Is there such a forum?
> 
> I'm in the b) category myself, but I'd really like to hear some arguments from
> those in the a) camp to show me the one true way. 
> 

Have you seen this forum?  http://forums.mozillazine.org/viewtopic.php?t=382152

You won't find many arguments from people in the a) camp though from what I have seen.