328070 - opt-in UI for data collection

Status: RESOLVED FIXED

(Toolkit Graveyard :: Data Collection/Metrics, defect, P5)

Description

[Brian Ryner (not reading)]

Comment 1

[Alex Polvi]

It seems like this should happen via the preference pane. Maybe under "Advanced / General"? Beltzner, any suggestions?

Additionally, it would be neat to randomly prompt a set of beta users to toggle this on and off. 

Comment 2

[Alex Polvi]

The setting should live under Preferences -> Privacy -> Private Data... still working on the message.

Comment 3

[Alex Polvi]

(In reply to comment #2)
> The setting should live under Preferences -> Privacy -> Private Data... still
> working on the message.

We need a check box and the localizable message, "Help us make Firefox better by sending anonymous usage statistics".

The check box should default to the current value of metrics.upload.enable, then toggle the pref as requested. It should be located directly under "Ask me before clearing private data", following the same form.

Comment 4

[Pete Collins (MDG)]

Well, while implementing this I ran into a problem with adding an overlay to:
 chrome://browser/content/preferences/privacy.xul

If I load the uri directly in the browser it works fine however, from the preferences dialog this is loaded in preferences.xml via document.loadOverlay

 http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/preferences.xml#688

It seems when an overlay is loaded in this manor and there is an additional overlay for the document, it doesn't work.

I get this exception:

  JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMXULDocument.loadOverlay]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://global/content/bindings/preferences.xml :: showPane :: line 651"  data: no]


So this is a bug that will block the metrics UI implementation.

I haven't searched bz yet for this bug to see if it is filed. 

Comment 5

[Pete Collins (MDG)]

Yes looks like bug 330458 is the same problem described in comment #4

Comment 6

[Alex Polvi]

What is the work-around? Choosing a different location?

Comment 7

[Pete Collins (MDG)]

The work around is hooking into the UI where the overlay is not loaded via document.loadOverlay. 

Maybe Tools->Metrics menu ...

I do think that the privacy pane is the right place for this.

Comment 8

[Pete Collins (MDG)]

I think what we should do is implement this UI control the way it is originally supposed to be. Since we are on the trunk, dealing w/ blocker bugs is just a way of life.

Maybe we can help push the bug fix we need through or look at it ourselves to help expedite things ...

Comment 9

[Alex Polvi]

(In reply to comment #8)
> I think what we should do is implement this UI control the way it is originally
> supposed to be. Since we are on the trunk, dealing w/ blocker bugs is just a
> way of life.

The bug was nominated and rejected as a blocker... we'll have to route around the issue for now.

> Maybe we can help push the bug fix we need through or look at it ourselves to
> help expedite things ...

If you think it would be very trivial to fix, let me know -- and we can discuss fixing that as a separate project. 

New plan for the UI:

Just add the checkbox and message to Preferences of the extension itself. This should consist of a XUL window containing a checkbox, the message, and a close button. 

Comment 10

[Pete Collins (MDG)]

> New plan for the UI:
> 
> Just add the checkbox and message to Preferences of the extension itself. This
> should consist of a XUL window containing a checkbox, the message, and a close
> button. 


Ok, will do ...

Comment 11

[Pete Collins (MDG)]

Attachment: metrics UI patch

Alex, please apply and take a look at this patch to ensure it is what you are looking for. Afterwards I can get review and then land.

Comment 12

[Alex Polvi]

(In reply to comment #11)
> Created an attachment (id=291503) [details]
> metrics UI patch
> 
> Alex, please apply and take a look at this patch to ensure it is what you are
> looking for. Afterwards I can get review and then land.

Looks good ... just make sure it uses "Help us make Firefox better
by sending anonymous usage statistics" and is localizable if needed.

Comment 13

[Pete Collins (MDG)]

Attachment: updated patch w/ blurb

Comment 14

[Pete Collins (MDG)]

Jan, can I get a review on this patch which provides a UI hook to turn metrics on/off from Tools->Add-ons->Metrics->Preferences.

Comment 15

[Pete Collins (MDG)]

Ok, UI patch has landed.

Comment 16

[Pete Collins (MDG)]

Attachment: jar.mn

forgot to include the jar manifest file ...

Comment 17

[Pete Collins (MDG)]

on OSX there shouldn't be a close button. As on windows OK and Cancel buttons are inserted in the dialog automatically where on OSX no buttons are added. 

If you look at the Firefox preferences panel, the dialog is closed via the OS "x" in the titlebar.

Comment 18

[Pete Collins (MDG)]

Attachment: proposed patch

I also noticed that the prefs dialog is not turning the pref on and off on win32 but it is working fine on OSX.

I need to test on Linux ...

Comment 19

[Pete Collins (MDG)]

I take that back it is working on win32 ...

Comment 20

[Pete Collins (MDG)]

Jan, can you review attachment 292607 [details] [diff] [review] UI change? 

Comment 21

[Jim Jeffery not reading bug-mail 1/2/11]

I just downloaded the latest hourly, and I see no UI to turn this on/off:

Hidden Pref? Tools-?Options->Privacy right?

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008011015 Minefield/3.0b3pre Firefox/3.0 ID:2008011015

Comment 22

[Alex Polvi]

(In reply to comment #21)
> I just downloaded the latest hourly, and I see no UI to turn this on/off:

No moz builds include the extension. You would have to build it yourself and install it ... then you could find it under Add-ons > Metrics Collector > Preferences.

Comment 23

[Reed Loden [:reed]]

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/extensions/metrics&command=DIFF_FRAMESET&file=install.rdf&rev1=1.3&rev2=1.4&root=/cvsroot is wrong. If you want to make it available for all Firefox 3 versions, use "3.0.*". Reopening to get this fixed.

See https://addons.mozilla.org/en-US/firefox/blog/4 for more details.

Comment 24

[Pete Collins (MDG)]

Ok, I reverted install.rdf back ...

  <em:maxVersion>@FIREFOX_VERSION@</em:maxVersion>