Closed Bug 328302 Opened 18 years ago Closed 18 years ago

Cert Viewer: Prefix "raw bytes" display with size information

Categories

(Core Graveyard :: Security: UI, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: KaiE, Assigned: KaiE)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

As of today, unknown certificate properties are displays as HEX bytes.
It would be helpful to display the size in bytes and bits.

I propose to change the current display of:
  01 02 03 04 05 06 07 08 ....
  ....

to
  Size: 10 Bytes / 80 Bits
  01 02 03 04 05 06 07 08 ....
  ....

For example, this makes it easier to quickly get an idea about key sizes.
Attached patch Patch v1Splinter Review
Attaching proposed patch.

While the real change is a small chunk of new code, it was necessary to add an nssComponent parameter to function processRawBytes and all callers.
Attachment #212883 - Flags: review?(rrelyea)
Comment on attachment 212883 [details] [diff] [review]
Patch v1

r+=relyea.
Attachment #212883 - Flags: review?(rrelyea) → review+
Attachment #212883 - Flags: approval-branch-1.8.1+
fixed trunk and 1.8 branch
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: