Closed
Bug 328373
Opened 18 years ago
Closed 18 years ago
Fix compiler warning for gcc compiles
Categories
(Core Graveyard :: Error Console, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: daumling, Assigned: daumling)
Details
Attachments
(1 file)
1.06 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
The compiler warning is: jsdbgapi.c: In function 'JS_EvaluateInStackFrame': jsdbgapi.c:943: warning: passing argument 3 of 'js_InflateString' from incompatible pointer type
Assignee | ||
Comment 1•18 years ago
|
||
mrbkap, could you review? Very simple patch.
Attachment #212967 -
Flags: review?(mrbkap)
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Comment 2•18 years ago
|
||
Comment on attachment 212967 [details] [diff] [review] Add local variable of type size_t and assign the result r=mrbkap
Attachment #212967 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 3•18 years ago
|
||
Fix checked in (jsdbgapi.c #3.61)
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 4•18 years ago
|
||
There are a large number of compiler warnings in js/src - mainly uninitialised variables e.g. src/js/src/jsdtoa.c:1235: warning: 'rv0' may be used uninitialized in this function Is this considered a problem, and would patches be considered? Since this is rather low priority work (it is on code that works and is almost certainly correct, and there is the potential for harm), should there be a Mozilla janitors scheme within which items like this could be posted and perhaps picked up by a dev as and when? There are also quite a few warnings elsewhere, notably src/layout/svg, but sufficient unto the day. Incidentally, compiler warnings if left alone do get fixed, I am just wondering out loud whether the Mozilla team wants people to attend to this or whether it is a distraction. Speaking personally, it is a nuisance when compiling a project to see unnecessary output; as in a large project any amount may be multiplied by thousands of files and millions of lines of code; but perhaps I am in a minority of one ...
Updated•16 years ago
|
Product: Core → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•