328407 - configure and Makefile include .svn directories if run from inside a subversion repository

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox2, defect)

Description

[Mike Taylor [:bear]]

This bug is courtesy of John L. Villalovos and was sent to me via email.

His two patches allow the configure and Makefile script to handle excluding .svn directories if they are run from a Tinderbox2 subversion working directory.

I modified his patches in a minor fashion.

Comment 1

[Mike Taylor [:bear]]

Attachment: patch to exclude .svn files in configure and Makefile when they look for perl code

Comment 2

[Benjamin Smedberg]

Comment on attachment 212994 [details] [diff] [review]
patch to exclude .svn files in configure and Makefile when they look for perl code

I don't own (or know anything about) tinderbox2. Bumping to timeless.

Comment 3

[timeless]

Comment on attachment 212994 [details] [diff] [review]
patch to exclude .svn files in configure and Makefile when they look for perl code

for the record, i seem to recall actively complaining about this code. i wanted something that whitelisted stuff that made sense instead of blacklisting things that didn't make sense.

that said, if this is really only supposed to be about the second patched file, then i'd probably review+ just that patch.

Comment 4

[Mike Taylor [:bear]]

Attachment: patch to exclude .svn directories in configure

removed the Makefile bits from the patch as they don't apply to this bug

Comment 5

[Mike Taylor [:bear]]

patch applied in revision 1.25