Closed Bug 328560 Opened 18 years ago Closed 17 years ago

Add UI to select a custom alarm sound in Lightning preferences

Categories

(Calendar :: Preferences, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Lightning 0.5

People

(Reporter: ssitter, Assigned: ssitter)

References

Details

Attachments

(1 obsolete file)

Add UI to select a custom alarm sound file in Lightning preferences.

This might include 
- use default sound (e.g. simple beep or a system sound)
- use custom sound (file browser)
- preview button to play the selected sound

We might consider making the UI similar to the UI that Thunderbird already uses for the new mail sound selection. (You know, that thing about familiarness)
Flags: blocking0.3+
Whiteboard: [depends on ui in bug 331323]
Whiteboard: [depends on ui in bug 331323] → [depends on ui in bug 331323][swag:.25d]
Attached patch port sunbird filepicker (obsolete) — — Splinter Review
Patch ports the Sunbird sound-picker to Lightning.
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #231807 - Flags: first-review?(dmose)
Whiteboard: [depends on ui in bug 331323][swag:.25d] → [patch in hand][swag:.25d]
Whiteboard: [patch in hand][swag:.25d] → [patch in hand][swag:.25d][cal-ui-review needed]
Got a screenshot?
(In reply to comment #2)
> Got a screenshot?
> 
It's identical to Sunbird's dialog.
Whiteboard: [patch in hand][swag:.25d][cal-ui-review needed] → [patch in hand][cal-ui-review needed]
Whiteboard: [patch in hand][cal-ui-review needed] → [patch in hand][cal-ui-review needed][no l10n impact]
This needs the fix from bug 344535 before landing.

Boo for code duplication
This should not block 0.3. It's at best a nice-to-have for 0.5
We can live without this for 0.3. (that doesn't mean that the patch can't get checked in, if it gets reviewed in time)
Flags: blocking0.3+ → blocking0.3-
Depends on: 372014
Attachment #231807 - Flags: first-review?(dmose)
Attachment #231807 - Attachment is obsolete: true
Assignee: jminta → ssitter
Status: ASSIGNED → NEW
Whiteboard: [patch in hand][cal-ui-review needed][no l10n impact]
Target Milestone: --- → Lightning 0.5
FIXED by checkin for bug 372014
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Component: Lightning Only → Preferences
QA Contact: lightning → preferences
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: