329163 - No 'settings' template case in generic auth code

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Vlad Dascalu]

https://bugzilla.mozilla.org/editsettings.cgi reports:

>>  Sorry, you aren't a member of the 'tweakparams' group, and so you are not authorized to modify . <<

(for non-bmo admins)

In editsettings.cgi we actually do:

$user->in_group('tweakparams')
  || ThrowUserError("auth_failure", {group  => "tweakparams",
                                     action => "modify",
                                     object => "settings"});

but we have no 'settings' case in the user-error.html.tmpl template. Looks like we must modify it, since reusing 'parameters' would be kind of inappropiate.

Comment 1

[Vlad Dascalu]

Attachment: Version 1

Comment 2

[Frédéric Buclin]

Comment on attachment 213810 [details] [diff] [review]
Version 1

looks good. r=LpSolit

Comment 3

[Vlad Dascalu]

Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.154; previous revision: 1.153
done

Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.145.2.2; previous revision: 1.145.2.1
done

Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.115.2.10; previous revision: 1.115.2.9
done