329283 - Necko should be agnostic about where Cache dir lives

Status: RESOLVED WORKSFORME

(Core :: Networking: Cache, defect)

Description

[Håkan Waara]

In the process of fixing bug 323780 (Make Camino's profile dir path be customizable), we need to be able to keep the Cache inside the profile directory.

However, Necko has some code that, if it doesn't find the cache dir at first, will try to remove the in-profile cache as a way of migrating old Firefox users (where Firefox kept the cache in the profile dir).

This code can't live in necko if embeddors such as Camino decides to have the cache in the profile. Thus we need to remove this code, or move it to some Firefox-specific location.

See http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/netwerk/cache/src/nsCacheService.cpp#342

Comment 1

[Benjamin Smedberg]

I'm not sure I understand... necko still keeps the cache in the profile unless you also specify a "local profile" directory... are you doing that?

Comment 2

[Håkan Waara]

(In reply to comment #1)
> I'm not sure I understand... necko still keeps the cache in the profile unless
> you also specify a "local profile" directory... are you doing that?

So after looking some more, I think I understand the logic now; the code is there to enforce precedence of a specified "local profile" to a "shared profile".

Since our directory provider doesn't care about any of these two properties, I *think* this code should never get executed in our case...

Comment 3

[Darin Fisher]

Why aren't the current directory service keys sufficient for you to configure the cache the way you like?  There doesn't seem to be anything to fix here.

Comment 4

[Håkan Waara]

(In reply to comment #3)
> Why aren't the current directory service keys sufficient for you to configure
> the cache the way you like?  There doesn't seem to be anything to fix here.

They are sufficient, we were just worried that necko might obliterate the cache if we put it in the profile dir.

Thanks for helping clear the confusion. :-)