Closed Bug 329289 Opened 18 years ago Closed 18 years ago

sidebar.xul.tmpl generates version info in output .html

Categories

(Bugzilla :: Bugzilla-General, defect)

Product:
Bugzilla
Component:
Bugzilla-General
Version:
2.16.11
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 3.0

People

(Reporter: LpSolit, Assigned: LpSolit)

Details

Attachments

(3 files)

patch for 2.20 - 2.23, v1
1.49 KB, patch
goobix
: review+
Details | Diff | Splinter Review
patch for 2.18, v1
1.45 KB, patch
goobix
: review+
Details | Diff | Splinter Review
patch for 2.16, v1
1.56 KB, patch
goobix
: review+
Details | Diff | Splinter Review 
[% template_version = "1.0@bugzilla.org" %] should be [%# 1.0@bugzilla.org %]

        Attachment #213940 -
        Flags: review?(vladd)

    
    

    
  


  

        Attachment #213941 -
        Flags: review?(vladd)

    
    

    
  


  

        Attachment #213942 -
        Flags: review?(vladd)

    
    

    
  
We kind of sorted this out in bug 329295 (tinderbox was failing due to this and now we know why).

But nevertheless, we can still apply those changes if we want to -- we used to have the template version in HTML, and 1.0@bugzilla.org received all the spam in the world :) Today we kind of keep the version in the .tmpl files only.
Assignee: general → LpSolit

    
  

        Attachment #213940 -
        Flags: review?(vladd) → review+

    
    

    
  
Comment on attachment 213941 [details] [diff] [review]
patch for 2.18, v1

Not sure if it makes sense to do that on locked-down branches, but david/myk will decide that.

        Attachment #213941 -
        Flags: review?(vladd) → review+

    
  

        Attachment #213942 -
        Flags: review?(vladd) → review+

    
  
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval2.22?
Flags: approval2.20?
Flags: approval2.18?
Flags: approval2.16?
Summary: sidebar.xul.tmpl has a bad header → sidebar.xul.tmpl generates version info in output .html

    
    

    
  
This doesn't seem like the kind of thing we need to fix in earlier releases, but cc:ing Dave for his opinion.
Flags: approval? → approval+

    
    

    
  
Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--  filterexceptions.pl
new revision: 1.66; previous revision: 1.65
done

Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Flags: approval2.22?
Flags: approval2.20?
Flags: approval2.18?
Flags: approval2.16?
Resolution: --- → FIXED
Target Milestone: Bugzilla 2.16 → Bugzilla 2.24

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: