Closed Bug 329615 Opened 18 years ago Closed 16 years ago

null comptr dereference when manifest contains path with missing drive

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: enndeakin, Assigned: enndeakin)

Details

Attachments

(1 file)

add nullcheck, this code is only called for debug anyway
1.52 KB, patch
benjamin
: review+
Details | Diff | Splinter Review 
If I use a ext.manifest file with

content tests file:///tests/

I get a null COMPtr dereference at:

http://lxr.mozilla.org/mozilla/source/chrome/src/nsChromeProtocolHandler.cpp#599 as the file is null:

file->Exists(&exists);

Adding the drive letter works fine: file:///C|/tests/
Assignee: jag → enndeakin
Status: NEW → ASSIGNED

        Attachment #351176 -
        Flags: review?(bsmedberg)

    
  

        Attachment #351176 -
        Flags: review?(bsmedberg) → review?(benjamin)

    
  

        Attachment #351176 -
        Flags: review?(benjamin) → review+

    
    

    
  
Looks like this code when away yesterday anyway, so no longer needed ;)
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → WORKSFORME

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: