329698 - Write nsIAnnotationService::getAnnotations

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Brett Wilson]

Comment 1

[Brett Wilson]

Attachment: Patch

Please check memory management carefully and don't assume I know what I'm doing. It's easy to mess up with the stupid XPCOM arrays.

Comment 2

[Joe Hughes]

Comment on attachment 214448 [details] [diff] [review]
Patch

Could you rename GetPageAnnotations to GetPageAnnotationNames, as it's more descriptive (since we aren't getting the annotation contents in this function).  Also, since I don't have much experience with the finer points of Moz memory management, I recommend finding an additional reviewer to look this over.  Otherwise looks good.

Comment 3

[Brett Wilson]

Attachment: Patch with functions renamed

Comment 4

[Brett Wilson]

Attachment: Patch with bryner's comments addressed

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 214456 [details] [diff] [review]
Patch with bryner's comments addressed

>--- src/nsAnnotationService.cpp	7 Feb 2006 22:57:56 -0000	1.8
>+++ src/nsAnnotationService.cpp	8 Mar 2006 19:44:44 -0000
>+NS_IMETHODIMP
>+nsAnnotationService::GetPageAnnotationNames(nsIURI* aURI, PRUint32* aCount,
>+                                            nsIVariant*** _result)
>+{
>+  *aCount = 0;
>+  *_result = nsnull;
>+
>+  nsTArray<nsCString> names;
>+  nsresult rv = GetPageAnnotationNamesTArray(aURI, &names);
>+  NS_ENSURE_SUCCESS(rv, rv);
>+  if (! names.Length())
>+    return NS_OK;

The general coding style is == 0 for integer comparisons, just so it's obvious that it's not a null pointer check.

>+  for (PRUint32 i = 0; i < names.Length(); i ++) {
>+    nsCOMPtr<nsIWritableVariant> var =
>+      do_CreateInstance(NS_VARIANT_CONTRACTID, &rv);

I'd prefer |new nsVariant()|, I guess (nsVariant is exported)

Comment 6

[Brett Wilson]

On branch and trunk.

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv