Closed Bug 329956 Opened 18 years ago Closed 18 years ago

Error: this.showBookmarkProperties is not a function (press Star)

Categories

(Firefox :: Bookmarks & History, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: Peter6, Assigned: bugs)

Details

(Keywords: regression)

Attachments

(1 file)

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060309 Firefox/1.6a1 ID:2006030911

repro:
1.open a tab
2.press on "star (ON/OFF)

result:

Error: this.showBookmarkProperties is not a function
Source file: chrome://browser/content/browser.js
Line: 5773
Summary: Error: this.showBookmarkProperties is not a function → Error: this.showBookmarkProperties is not a function (press Star)
Attached patch patchSplinter Review
call placescontroller method... 

update the placescontroller to open the dialog parented to the window the controller is instantiated in (this is reaosnable - will be the browser window or the organizer window)... 

also fix the updating UI function call to call the right function
Assignee: nobody → bugs
Status: NEW → ASSIGNED
Attachment #214602 - Flags: review?(joe)
Attachment #214602 - Flags: review?(joe) → review+
fixed branch and trunk
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: