330140 - Create New Calender: more calenders to be created

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Akihiro Kiya(aka. Mira)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060310 Mozilla Sunbird/0.3a1+

When I create a new calender, I forgot to set "color" to it and clicked NEXT.
Oops! I clicked BACK. Fixed color and go next again.
Something is strange. There are 2 calenders with same name! They are not needed.


Reproducible: Always

Steps to Reproduce:
1. Start "Create New Calender" Wizard
2. Click "NEXT"
3. Then click "BACK"
4. Change Settings and click "NEXT" again
5. Click "Finish"
Actual Results:  
There are 2 calenders created!

Expected Results:  
Only One calender must be created.

Comment 1

[Akihiro Kiya(aka. Mira)]

Oh? why Firefox user-agent shown? I pasted sunbird one.

Comment 2

[Robin Edrenius]

Confirming.

We should change so that the calendar isn't created before finish is pressed.

(The text in the last window would have to be changed as well, to something like "Press finish to create the calendar")

Comment 3

[Robin Edrenius]

Assigning to myself.

Comment 4

[Robin Edrenius]

Attachment: Patch v1

This patch changes when doCreateCalendar() is called. With this patch it's called when finish is pressed in the last page instead of when next is pressed in the page before.

Two l10n strings had to be changed as well.

Comment 5

[Joey Minta]

Comment on attachment 214773 [details] [diff] [review]
Patch v1

mvl is a better person for this review.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 214773 [details] [diff] [review]
Patch v1

No, this is the wrong solution. There should be page to indicate success or failure after creating a calendar. Creating a calendar can fail.
So the thing to do would be to disable 'back' when on the last page. And then we should actually test if creating the calendar succeeded.

Comment 7

[Robin Edrenius]

Attachment: Disable backbutton on last page

> So the thing to do would be to disable 'back' when on the last page.

This patch disables the backbutton on the last page of the wizard by setting canRewind to false.

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 214915 [details] [diff] [review]
Disable backbutton on last page

r=mvl

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in

Comment 10

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060929 Sunbird/0.3

Comment 11

[Damian Szczepanik]

Litmus testcase 2609 created