330633 - Remove the "Reset Form" button on editparams.cgi

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[:glob ✱]

remove the reset button on editparams.cgi.

it's useless and confusing, especially for these young upstarts who don't remember when every html form had a reset button :)

Comment 1

[Max Kanat-Alexander]

I think this sounds like a good idea.

Comment 2

[Teemu Mannermaa (:wicked)]

Ooh, yes please! It's especially awful because it's the default (first from left) button on the page. I think I have managed to click it when I was going to commit and you know what then happened. :)

Comment 3

[Vlad Dascalu]

Another idea would be to disable (make read-only) the text-field, when the reset button in selected.

Comment 4

[Vlad Dascalu]

Related incident: bug 333682

Comment 5

[Dave Miller [:justdave]]

(In reply to comment #3)
> Another idea would be to disable (make read-only) the text-field, when the
> reset button in selected.

Not related, although it's still a good idea.  This bug is talking about the "Reset Form" button at the bottom, not the checkboxes.  And yes, that should go away, too.

Comment 6

[Max Kanat-Alexander]

Looks like Firefox did some strange selecting of the group radio boxes on the mass-change page when I clicked refresh in my browser before that last mass-change. This is not really a security bug. :-)

Comment 7

[Frédéric Buclin]

This bug is retargetted to Bugzilla 3.2 for one of the following reasons:

- it has no assignee (except the default one)
- we don't expect someone to fix it in the next two weeks (i.e. before we freeze the trunk to prepare Bugzilla 3.0 RC1)
- it's not a blocker

If you are working on this bug and you think you will be able to submit a patch in the next two weeks, retarget this bug to 3.0.

If this bug is something you would like to see implemented in 3.0 but you are not a developer or you don't think you will be able to fix this bug yourself in the next two weeks, please *do not* retarget this bug.

If you think this bug should absolutely be fixed before we release 3.0, either ask on IRC or use the "blocking3.0 flag".

Comment 8

[Max Kanat-Alexander]

Bugzilla 3.2 is now frozen. Only enhancements blocking 3.2 or specifically approved for 3.2 may be checked in to the 3.2 branch. If you would like to nominate your enhancement for Bugzilla 3.2, set the "blocking3.2" flag to "?". Then, either the target milestone will be changed back, or the blocking3.2 flag will be granted, if we will accept this enhancement for Bugzilla 3.2.

This particular bug has not been touched in over eight months, and thus is being retargeted to "---" instead of "Bugzilla 4.0". If you believe this is a mistake, feel free to retarget it to Bugzilla 4.0.

Comment 10

[Reed Loden [:reed]]

Attachment: patch - v1

Comment 11

[Max Kanat-Alexander]

Comment on attachment 433104 [details] [diff] [review]
patch - v1

I agree, and this looks good to me.

Comment 12

[Max Kanat-Alexander]

  Need LpSolit to approve, though, since he's sort of the params owner.

Comment 13

[Reed Loden [:reed]]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/admin/params/editparams.html.tmpl
Committed revision 7071.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/
modified template/en/default/admin/params/editparams.html.tmpl
Committed revision 7037.