Closed Bug 330946 Opened 18 years ago Closed 18 years ago

Can drag bookmarks into address book collection of Show All Bookmarks

Categories

(Camino Graveyard :: Bookmarks, defect)

Product:
Camino Graveyard
Component:
Bookmarks
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: john, Assigned: bugzilla-graveyard)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

invalidates drop if it's going to occur on a smart folder's outline view
1.94 KB, patch
moz
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.2) Gecko/20060310 Camino/1.0.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.2) Gecko/20060310 Camino/1.0.0+

This is bad. It makes no sense to do so, and after you do you cannot delete them. Quitting and relauching Camino gets rid of them.

Reproducible: Always

Steps to Reproduce:
1. Drag bookmarks (or maybe copy and paste as well) to the address book section.
2. Ow.
3.



Expected Results:  
Told me I'm an idiot for trying to do this.
Confirming.  You can't drop onto the collection, but you can drop onto the table once the collection is selected.  Definitely not so good.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Can drag bookmarks into address book section of Show All Bookmarks → Can drag bookmarks into address book collection of Show All Bookmarks
Assignee: mikepinkerton → nobody
QA Contact: bookmarks
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED

        Attachment #224328 -
        Flags: review?(mozilla)

    
    

    
  
Comment on attachment 224328 [details] [diff] [review]
invalidates drop if it's going to occur on a smart folder's outline view

Code looks good to me. r+

        Attachment #224328 -
        Flags: review?(mozilla) → review+

    
  

        Attachment #224328 -
        Flags: superreview?(mikepinkerton)

    
    

    
  
Comment on attachment 224328 [details] [diff] [review]
invalidates drop if it's going to occur on a smart folder's outline view

sr=pink

        Attachment #224328 -
        Flags: superreview?(mikepinkerton) → superreview+

    
  
Whiteboard: [needs checkin]

    
    

    
  
Fixed trunk and 1.8 branch
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
  
Keywords: fixed1.8

    
  
Whiteboard: [needs checkin]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: