331031 - use system smooth scrolling pref

Status: RESOLVED WONTFIX

(Core :: Widget: Cocoa, enhancement)

Description

[jacob berkman]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en) AppleWebKit/417.9 (KHTML, like Gecko) Safari/417.9.2
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.2) Gecko/20060319 Firefox/1.5.0.2

In OS X 10.4 (likely earlier), there is a "Use Smooth Scrolling" in System Preferences -> Appearance.

Firefox should probably use this instead of its "Use smooth scrolling" option.

The following can get this pref from the command line in 10.4:

$ defaults read .GlobalPreferences AppleScrollAnimationEnabled
1


Reproducible: Always

Comment 1

[Jo Hermans]

Related bug in Seamonkey : bug 236417.

Comment 2

[Adam Guthrie]

*** Bug 362377 has been marked as a duplicate of this bug. ***

Comment 3

[Håkan Waara]

Attachment: Proposed fix

Here's a fix that makes the view code respect the system setting. It also removes the UI for the pref.  Roc, are you the right man for the review? I can have someone else look at the UI change if you want.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'd prefer you to add this through nsILookAndFeel.

Comment 5

[Håkan Waara]

Attachment: Go through lookAndFeel instead

Something like this?

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 247270 [details] [diff] [review]
Go through lookAndFeel instead

actually, one thing... you should make ShouldSmoothScroll be pure virtual in nsILookAndFeel, and add the default implementation of it to nsXPLookAndFeel.

Comment 7

[Håkan Waara]

Attachment: Patch v2

Ok, this implements the ShouldSmootScroll() method in nsXPLookAndFeel as suggested in the last comment.

Mano, please see the browser/ change.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

One more thing. Can you update NS_ILOOKANDFEEL_IID to a new IID? Thanks.

Comment 9

[Asaf Romano (gone)]

Comment on attachment 247480 [details] [diff] [review]
Patch v2

This abuses nsILookAndFeel IMO. We should rather handle this the way other system-based prefs are handled, i.e. rely on the system preference only if it is not overridden. In other words, you should use the GetMetric system, see bug 187508 for example.

Comment 10

[Håkan Waara]

(In reply to comment #9)
> (From update of attachment 247480 [details] [diff] [review] [edit])
> This abuses nsILookAndFeel IMO. We should rather handle this the way other
> system-based prefs are handled, i.e. rely on the system preference only if it
> is not overridden. In other words, you should use the GetMetric system, see bug
> 187508 for example.

Abuses how? I don't see why this matters. We just need to return the boolean in one way or another, and I did it on Roc's suggestion. 

Mac overrides with the system pref, other platforms that don't have a native pref for this continue like before, which is the change this bug suggests.

Comment 11

[Asaf Romano (gone)]

You should be able to override the system pref from about:config by adding the pref manually, see how GetMetric works.

Comment 12

[Florian Bender]

This should not negatively affect Bug 964097 (though that's unlikely). Bug 640663 is about a somehow related OS X scrolling issue.

Comment 13

[MarjaE]

I can't find that preference under its old location or name. I suggest closing this bug if that preference has been removed.

Since smooth scrolling can be a migraine trigger, Firefox should retain some way to disable smooth scrolling regardless of whether the system has this preference.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:spohl, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 15

[Stephen A Pohl [:spohl]]

Agree with comment 13. The system pref appears to have been removed from System Preferences > Appearance.