33192 - Important RDF Progids not defined in nsI*.h files

Status: RESOLVED WONTFIX

(Core Graveyard :: RDF, defect, P3)

Description

[edburns]

The following progids should be defined in nsI*.h files.  I've had to manually 
define them in order to access the components they reference:

static const char *NS_RDFSERVICE_PROGID = "component://netscape/rdf/rdf-
service";
static const char *NS_CONTAINERUTILS_PROGID 
= "component://netscape/rdf/container-utils";
static const char *NS_RDFCONTAINER_PROGID 
= "component://netscape/rdf/container";

Comment 1

[Dawn Endico]

reassigning to brendan and ccing waterson

Comment 2

[Brendan Eich [:brendan]]

Sounds like an RDF bug.

/be

Comment 3

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Progids should not be in nsI*.h files.  progIDs identify implementations, and
the ``I'' in nsI*.h stands for ``interface''.

You want an rdf-progids.h, perhaps, which lists all the progids for our RDF
components.  You don't want (and, more strongly, I don't want for you =) )
implementation labels mixed into interface headers, though this misguided
practice isn't uncommon in our tree.

(Would you have all of the widget progids in nsIWidget.h?  All the progids in
the product tacked onto the end of nsISupports.h?  Folly, I say.)

Comment 4

[Chris Waterson]

Sure, I'll put a bunch of #defines into mozilla/rdf/base/public/rdf.h. Sounds
like a good idea.

Comment 5

[Chris Waterson]

Ed, can you give me patches? thanks...

Comment 6

[edburns]

I don't think a patch will help, since my changes were in the file 

mozilla/java/webclient/src_moz/rdf_util.h

but here's the relevent data:

rdf_util.h:static const char *NS_IRDFSERVICE_PROGID =
"component://netscape/rdf/rdf-service";
rdf_util.h:static const char *NS_ICONTAINERUTILS_PROGID =
"component://netscape/rdf/container-utils";
rdf_util.h:static const char *NS_IBOOKMARKSSERVICE_PROGID =
"component://netscape/browser/bookmarks-service";
rdf_util.h:static const char *NS_IRDFCONTAINER_PROGID =
"component://netscape/rdf/container";


I'm reassigning this to waterson.

Comment 7

[edburns]

Chris, any progress on this?

Ed

Comment 8

[Chris Waterson]

i'm not going to fix this.