332009 - submission action="mailto.." not working

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Steve Speicher]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060328 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060328 Firefox/1.6a1

Whenever the submission action is mailto, no action is invoked (does nothing). This was working, see bug 301571

This fails test cases: 11.2.m/p/q/r

Reproducible: Always

Comment 1

[Steve Speicher]

Attachment: test case

Comment 2

[aaronr]

I think that Doron said that this works on Linux but sure doesn't work on Windows.  Not even the 1.8.0.2 nightly, so not a regression.

Comment 3

[Doron Rosenberg (IBM)]

The problem on windows seems to be NS_EscapeURL barfing on a character (seems to be a newline one).

I think the code probably needs to be redone anyways, it is rather hacky.

Comment 4

[Merle Sterling]

Attachment: Correct parameters for NS_EscapeURL

The main problem was that the order of the parameters in the call to NS_EscapeURL was incorrect and the length of the url to encode was being treated as the flags and vice-versa. The encoded URL becomes way larger than the 2K limit.

Note also that with esc_AlwaysCopy as the only flag, every single character will be url encoded and the size of the message increases by a factor of 3. That would limit the size of messages we could mail to about 660 chars or so.  Added esc_Query to escape the xml body after ?body=. 

The spurious newline is properly encoded as %0A and does not cause a problem.

Comment 5

[Doron Rosenberg (IBM)]

Comment on attachment 218324 [details] [diff] [review]
Correct parameters for NS_EscapeURL

Stupid me (http://lxr.mozilla.org/seamonkey/source/xpcom/io/nsEscape.h#140)

Comment 6

[aaronr]

Comment on attachment 218324 [details] [diff] [review]
Correct parameters for NS_EscapeURL

doron did the official review for me since he did this code originally.  Looks good to me, too.

Comment 7

[Allan Beaufour]

Fixed on trunk.