Closed
Bug 333025
Opened 18 years ago
Closed 18 years ago
Three relatively frequent mozilla/accessible crashes in talkback
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: aaronlev, Assigned: aaronlev)
References
Details
(5 keywords)
Attachments
(1 file)
2.80 KB,
patch
|
pilgrim
:
review+
neil
:
superreview+
ginnchen+exoracle
:
approval-branch-1.8.1+
dveditz
:
approval1.8.0.4+
|
Details | Diff | Splinter Review |
The following 3 crashes reoccur fairly regularly in talkback. http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=17265983 http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=17265867 http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=17264754 I'd like to take care of them all at once.
Assignee | ||
Comment 1•18 years ago
|
||
Attachment #217449 -
Flags: superreview?(neil)
Attachment #217449 -
Flags: review?(pilgrim)
Updated•18 years ago
|
Attachment #217449 -
Flags: superreview?(neil) → superreview+
Updated•18 years ago
|
Summary: Three relatively mozilla/accessible crashes in talkback → Three relatively frequent mozilla/accessible crashes in talkback
Updated•18 years ago
|
Attachment #217449 -
Flags: review?(pilgrim) → review+
Assignee | ||
Comment 2•18 years ago
|
||
Comment on attachment 217449 [details] [diff] [review] Improved null checks (whitespace changes removed) . In one case I still don't know how it happens, but hopefully the assertion will help us catch it in a debug build at some point. Ginn, I shouldn't a= my own patches.
Attachment #217449 -
Flags: approval-branch-1.8.1?(ginn.chen)
Assignee | ||
Updated•18 years ago
|
Attachment #217449 -
Flags: approval1.8.0.2?
Assignee | ||
Updated•18 years ago
|
Blocks: fox2access
Comment on attachment 217449 [details] [diff] [review] Improved null checks (whitespace changes removed) . In one case I still don't know how it happens, but hopefully the assertion will help us catch it in a debug build at some point. a=me
Attachment #217449 -
Flags: approval-branch-1.8.1?(ginn.chen) → approval-branch-1.8.1+
Comment 4•18 years ago
|
||
Comment on attachment 217449 [details] [diff] [review] Improved null checks (whitespace changes removed) . In one case I still don't know how it happens, but hopefully the assertion will help us catch it in a debug build at some point. 1.8.0.2 is done, moving aaron's request to 1.8.0.3
Attachment #217449 -
Flags: approval1.8.0.2? → approval1.8.0.3?
Assignee | ||
Updated•18 years ago
|
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•18 years ago
|
Keywords: fixed1.8.1
Comment 5•18 years ago
|
||
Comment on attachment 217449 [details] [diff] [review] Improved null checks (whitespace changes removed) . In one case I still don't know how it happens, but hopefully the assertion will help us catch it in a debug build at some point. approved for 1.8.0 branch, a=dveditz for drivers
Attachment #217449 -
Flags: approval1.8.0.3? → approval1.8.0.3+
Checking in src/base/nsDocAccessible.cpp; /cvsroot/mozilla/accessible/src/base/nsDocAccessible.cpp,v <-- nsDocAccessible.cpp new revision: 1.73.2.6.2.1; previous revision: 1.73.2.6 done Checking in src/msaa/nsDocAccessibleWrap.cpp; /cvsroot/mozilla/accessible/src/msaa/nsDocAccessibleWrap.cpp,v <-- nsDocAccessibleWrap.cpp new revision: 1.30.2.4.2.1; previous revision: 1.30.2.4 done
Keywords: fixed1.8.0.3
You need to log in
before you can comment on or make changes to this bug.
Description
•