333178 - fix image cursors for cairo-gtk2 builds

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Image cursors are broken because nsThebesImage doesn't implement nsIGdkPixbufImage.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Stuart Parmenter]

Comment on attachment 217623 [details] [diff] [review]
patch

i'd really rather not take this patch.  we want to remove our deps on nsIImage and the rest of the GFX APIs as much as possible.  Can this code live somewhere else?

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

hm... I suppose so, but it's used by widget as well as http://lxr.mozilla.org/seamonkey/source/browser/components/shell/src/nsGNOMEShellService.cpp#356

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Yes, the fix for this needs to happen in widget code, not in gfx; same for that WriteImage stuff.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

maybe like this then?

Comment 6

[Brian Ryner (not reading)]

Comment on attachment 217690 [details] [diff] [review]
patch v2

Looks ok... the comments about nsIGdkPixbufImage will be confusing when that interface goes away though.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2, merged to trunk

oops, I forgot about this patch...

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Why don't you just create a GdkPixbuf, wrap it in a gfxContext, and draw the image into that?

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Cairo does not support the pixel format of GdkPixbuf. GdkPixbuf wants non-premultiplied RGBA (big-endian byte order).

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

sorry, I confused GdkPixbuf with GdkPixmap.

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in browser/components/shell/src/nsGNOMEShellService.cpp;
/cvsroot/mozilla/browser/components/shell/src/nsGNOMEShellService.cpp,v  <--  nsGNOMEShellService.cpp
new revision: 1.13; previous revision: 1.12
done
Checking in widget/src/gtk2/Makefile.in;
/cvsroot/mozilla/widget/src/gtk2/Makefile.in,v  <--  Makefile.in
new revision: 1.53; previous revision: 1.52
done
RCS file: /cvsroot/mozilla/widget/src/gtk2/nsIImageToPixbuf.h,v
done
Checking in widget/src/gtk2/nsIImageToPixbuf.h;
/cvsroot/mozilla/widget/src/gtk2/nsIImageToPixbuf.h,v  <--  nsIImageToPixbuf.h
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/widget/src/gtk2/nsImageToPixbuf.cpp,v
done
Checking in widget/src/gtk2/nsImageToPixbuf.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsImageToPixbuf.cpp,v  <--  nsImageToPixbuf.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/widget/src/gtk2/nsImageToPixbuf.h,v
done
Checking in widget/src/gtk2/nsImageToPixbuf.h;
/cvsroot/mozilla/widget/src/gtk2/nsImageToPixbuf.h,v  <--  nsImageToPixbuf.h
initial revision: 1.1
done
Checking in widget/src/gtk2/nsWidgetFactory.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsWidgetFactory.cpp,v  <--  nsWidgetFactory.cpp
new revision: 1.36; previous revision: 1.35
done
Checking in widget/src/gtk2/nsWindow.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.173; previous revision: 1.172
done