333545 - In DEC/OSF1 build failure in mozilla/xpcom/stub directory

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Laxmi Harikumar]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: 

Mozilla build is failing in xpcom/stub directory with the following error:

cxx  -noexceptions -ieee -ptr ../../dist/cxx_repository -pthread  -DDEBUG -D_DEB
UG -DDEBUG_dailybld -DTRACING -g  -shared -msym -expect_unresolved \* -update_re
gistry ../../dist/so_locations -soname libxpcom.so -o libxpcom.so  nsXPComStub.o
    -lpthread          -L../../dist/bin -L../../dist/lib -Wl,-rpath-link,../../d
ist/bin -lxpcom_core -L../../dist/lib -lplds4 -lplc4 -lnspr4 -lpthread -lm -lc_r

ld (prelink):
-rpath-link: Unknown flag
ld: Usage: ld [options] file [...]
ld:
-rpath-link: Unknown flag
ld: Usage: ld [options] file [...]
gmake[5]: *** [libxpcom.so] Error 1
gmake[5]: Leaving directory `/usr4/dailybld/mozilla/xpcom/stub'


Reproducible: Always

Steps to Reproduce:
1. Go to mozilla/xpcom directory
2. Run make
3.

Actual Results:  
Build fails

Expected Results:  
Build should have completed without any errors

As mentioned in comment#6 Bug 332053,

this problem is caused by the modification of autoconf.mk.in file.

Comment 1

[Laxmi Harikumar]

Attachment: Patch for configure file

The solution is to override MOZ_FIX_LINK_PATHS for osf in configure file

Comment 2

[Benjamin Smedberg]

You almost certainly need a real replacement for fix-link-paths; see bug 332075 for what this variable needs to be able to do.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

and don't modify configure directly, it's autogenerated from configure.in.

Comment 4

[cls]

Comment on attachment 218000 [details] [diff] [review]
Patch for configure file

MOZ_FIX_LINK_PATHS needs to be set in the $target section, not the $host section (yes, darwin & os2 are bad examples).  The patch needs to be against configure.in, not configure.  I know that OSF1 supports -rpath.  Is that a suitable substitute or would we wind up hardcoding in a temporary build path?

Comment 5

[Benjamin Smedberg]

-rpath would end up hardcoding bad paths.

Comment 6

[Laxmi Harikumar]

Attachment: Patch in configure.in file

Thanks for the review comments.
As per the comments, I have put the patch in the $target section of configure.in. Also I am not using "-rpath" as a substitute.

Comment 7

[cls]

Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1691; previous revision: 1.1690
done