Closed Bug 333873 Opened 18 years ago Closed 18 years ago

bug 270893 broke building of the Spatial Navigation extension

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: roytam, Unassigned)

Details

Attachments

(1 file)

v1
915 bytes, patch
benjamin
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.2) Gecko/20060411 Firefox/1.5.0.2 (Firefox musume)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.2) Gecko/20060411 Firefox/1.5.0.2 (Firefox musume)

Got compilation error after cvs checkout ( http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=mozilla%2F&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-04-12+08%3A32&maxdate=2006-04-12+08%3A43&cvsroot=%2Fcvsroot ):
c:\moztrunk\mozilla\extensions\spatialnavigation\src\nsSpatialNavigationPrivate.h(49) : fatal error C1083: Cannot open include file: 'nsArray.h': No such file or directory
make[6]: *** [nsSpatialNavigationService.obj] Error 2

Reproducible: Always

Steps to Reproduce:
1.checkout from cvs
2.add "ac_add_options --enable-extensions=spatialnavigation" to .mozconfig
3.compile

Actual Results:  
Compilation failed with nsSpatialNavigationPrivate.h
c:\moztrunk\mozilla\extensions\spatialnavigation\src\nsSpatialNavigationPrivate.h(49) : fatal error C1083: Cannot open include file: 'nsArray.h': No such file or directory
make[6]: *** [nsSpatialNavigationService.obj] Error 2

Expected Results:  
Compiled successfully without any error.

This cause minimo can't be built.
Attached patch v1 — — Splinter Review 
Remove unused nsArray include.
Attachment #218416 - Flags: review?(benjamin)
Attachment #218416 - Flags: review?(benjamin) → review+
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: "Freeze nsIArray (requires separating nsIMutableArray into another .idl file); also removes NS_NewArray and moves do_QueryElementAt into the glue" cause Spatial Navigation extension can not be built → bug 270893 broke building of the Spatial Navigation extension
Was fixed as a part of another bug.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → WORKSFORME
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: