Closed Bug 334193 Opened 18 years ago Closed 18 years ago

nsContinueDespiteCertError's default case should set rv

Categories

(Core :: Security: PSM, defect)

Product:
Core
Component:
Security: PSM
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug,
URL
)

Details

(Keywords: coverity)

Attachments

(1 obsolete file) 

currently both code paths result in PR_FALSE being returned, but purify and valgrind would complain about the jump
Attached patch set rv (obsolete) — — Splinter Review 

        Attachment #218650 -
        Flags: superreview?(bzbarsky)

        Attachment #218650 -
        Flags: review?(kengert)

        Attachment #218650 -
        Flags: superreview?(bzbarsky) → superreview+

    
    

    
  
Comment on attachment 218650 [details] [diff] [review]
set rv

r=kengert

patch can't hurt and adds clarity

        Attachment #218650 -
        Flags: review?(kengert) → review+

    
    

    
  
Comment on attachment 218650 [details] [diff] [review]
set rv

mozilla/security/manager/ssl/src/nsNSSIOLayer.cpp 	1.108

        Attachment #218650 -
        Attachment is obsolete: true

    
  
Assignee: kengert → timeless

    
  
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: