Closed Bug 334236 Opened 18 years ago Closed 18 years ago

double free in PK11_ListPrivKeysInSlot if keys allocation fails

Categories

(NSS :: Libraries, defect, P2)

3.11
All
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED
3.11.1

People

(Reporter: timeless, Assigned: alvolkov.bgs)

References

()

Details

(Keywords: coverity, fixed1.8.0.10, fixed1.8.1.1, Whiteboard: [CID 311 310])

Attachments

(1 file)

found by coverity
Assignee: kengert → nobody
Severity: blocker → critical
Priority: -- → P2
Target Milestone: --- → 3.11.1
Version: 4.0 → 3.11
Hardware: PC → All
Attached patch fixSplinter Review
The code would crash even before second PORT_Free(key_ids) in case when objCount is grater 0, and keys is not allocated.
Assignee: nobody → alexei.volkov.bugs
Status: NEW → ASSIGNED
Attachment #219166 - Flags: review?(nelson)
Comment on attachment 219166 [details] [diff] [review]
fix

r=nelson

As with all these Coverity bugs, please fix on both trunk and 3.11 branch, and add the checkin messages (showing old and new revision numbers) to this bug.
Attachment #219166 - Flags: review?(nelson) → review+
tip:
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11akey.c,v  <--  pk11akey.c
new revision: 1.12; previous revision: 1.11

3.11 branch:
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11akey.c,v  <--  pk11akey.c
new revision: 1.9.2.2; previous revision: 1.9.2.1
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
*** Bug 337097 has been marked as a duplicate of this bug. ***
CID 311
Whiteboard: CID 311
Whiteboard: CID 311 → [CID 311 310]
should this fix get picked up for the 2.0.0.4 firefox release?
Flags: blocking1.8.1.4?
Flags: blocking1.8.1.4?
Group: security
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: