334846 - [FIX]Assertion after EnableGlobalHistory

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GRE Core, defect, P3)

Description

[Mikhail Zabaluev]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2
Build Identifier: 

I embed the Gecko engine built from Xulrunner trunk. On creation of a browser window, it fails an assertion in nsWebBrowser::Create after EnableGlobalHistory has failed. Continued execution after the assertion exhibits no problems, and my embedding application doesn't even intend to use history. I opt to disable it both via nsIWebBrowserSetup and the flag to nsIWebNavigation::LoadURI.

Reproducible: Always




Xulrunner built from trunk as of 2006-04-18.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: This should fix it

Benjamin, does this need sr?

Comment 2

[Mikhail Zabaluev]

The patch solves my problem, thank you.

Comment 3

[Darin Fisher]

Comment on attachment 219199 [details] [diff] [review]
This should fix it

Hmm... it might be nice to set mHistoryEnabled inside EnableGlobalHistory.  That way, mHistoryEnabled does not get out-of-sync if someone happens to call EnableGlobalHistory without manually updating mHistoryEnabled.

Also, does it make sense to set mHistoryEnabled to true if EnableGlobalHistory fails?

sr=darin

Comment 4

[Boris Zbarsky [:bzbarsky]]

mHistoryEnabled is just an indicator of what the setup boolean is.  I could rename it to mShouldSetUpHistoryOnCreate if that would help...

> Also, does it make sense to set mHistoryEnabled to true if EnableGlobalHistory
> fails?

Yes, since it doesn't indicate whether history is actually enabled but whether we _should_ enable it on create.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Updated to darin's comments

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed.