334863 - browser.urlbar.autoFill needs adding to prefs list

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Peter Kasting]

Bug 203756 added the browser.urlbar.autoFill pref for auto-filling the best match in the address bar.  However, the pref was never added to firefox.js, so it doesn't show up in about:config and must be newly added.

This bug seeks to add the pref, defaulted to off so as not to change behavior.  Bug 186136 has more discussion about broader issues such as fixing autoFill to suck less.  All I'm trying to do here is make the pref visible.

Comment 1

[Peter Kasting]

Keyed in the wrong bug number in the blocks list.

Comment 2

[Peter Kasting]

Attachment: Fix for firefox.js

Add the pref to firefox.js.

Since this is part of browser, it doesn't belong in all.js.

Comment 3

[Peter Kasting]

Comment on attachment 219196 [details] [diff] [review]
Fix for firefox.js

Tried to set this to get review from Ben Goodger, didn't seem to work.  Trying again.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 219196 [details] [diff] [review]
Fix for firefox.js

As a general note, there is no requirement to ensure prefs show up in about:config, but this one is not rare, though its far from commonly sought.

The dependency isn't necessary, but meh.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Peter: do you want me to check this in?

Comment 6

[Peter Kasting]

Yes please, since I don't have CVS privileges.

It would be nice to get this onto the 1.8 branch as well.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/app/profile/firefox.js 	1.106

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Checked in on the 1.8 branch too.
mozilla/browser/app/profile/firefox.js 	1.71.2.29