335001 - Build without JS_HAS_XML_SUPPORT fails

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andreas]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040914 (not Googlebot)
Build Identifier: CVS js

A build without JS_HAS_XML_SUPPORT fails. This means only JS_VERSION == 160
is working.


Reproducible: Always

Steps to Reproduce:
1. Try to build js with -DJS_VERSION=150



Support for JS_VERSION < 150 is even more broken. I started to fix it,
but it turned out to be much work, and probably nobody will ever use it.
So I suggest instead removing all support for JS_VERSION < 148 (ECMA 3).
Less #if JS_HAS_* will make the code more readable.

JS_VERSION < 120 (at least) was already broken in Mozilla Classic.

Comment 1

[Andreas]

Attachment: patch to make JS_VERSION=150 work

Comment 2

[Andreas]

Attachment: started work for JS_VERSION < 150, incomplete, will never be finished by me

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 219359 [details] [diff] [review]
patch to make JS_VERSION=150 work

Two issues:

* jspubtd.h should not include jsconfig.h, which is private.  The public API should be the same for any compile-time version.

* The jsproto.tbl #if JS_HAS_XML_SUPPORT is also problematic: JSProto_* enumerator values are part of the serialized data produced by the JS_XDR* APIs, which end up on disk in one's XUL FastLoad File.

The .c file changes look good.

/be

Comment 4

[Brendan Eich [:brendan]]

Brian, can you confirm this bug if real and update and land any needed patch? Thanks,

/be

Comment 5

[Brian Crowder]

Attachment: only change necessary for trunk build to work

Brendan:  this is the only change I needed to make the trunk build work.

Comment 6

[Brian Crowder]

Comment on attachment 219359 [details] [diff] [review]
patch to make JS_VERSION=150 work

This seems to change more than is necessary to build.

Comment 7

[Brendan Eich [:brendan]]

Comment on attachment 259103 [details] [diff] [review]
only change necessary for trunk build to work

Great -- thanks!

/be

Comment 8

[Brian Crowder]

jsscan.c: 3.123

Please re-open this if you continue to have build issues.  Perhaps some difference between Linux and Mac OS X is causing me to see different build complaints than you are.

Comment 9

[Bob Clary [:bc] (inactive)]

verified fixed trunk linux for -DJS_VERSION=150