Closed Bug 335129 Opened 18 years ago Closed 18 years ago

calIObserver.onAlarm is never called

Categories

(Calendar :: Internal Components, defect)

Product:
Calendar
Component:
Internal Components
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jminta, Assigned: jminta)

References

(
URL
)

Details

Attachments

(1 file)

remove calIObserver.onAlarm
13.40 KB, patch
dmosedale
: first-review+
Details | Diff | Splinter Review 
one would expect that calIObserver.onAlarm would be called whenever an alarm is fired.  This, however, is not the case.  It seems there's a bit of duplicate functionality between this and the alarmService.  Both are supposed to announce alarms, although only one works.
If the functionality is duplicated, just remove one. In this case, the one in calIObserver.
Attached patch remove calIObserver.onAlarm — — Splinter Review 
Removes calIObserver.onAlarm.  If you want to observe alarms, register yourself with calIAlarmService.
Assignee: base → jminta
Status: NEW → ASSIGNED
Attachment #220860 - Flags: first-review?(dmose)
Comment on attachment 220860 [details] [diff] [review]
remove calIObserver.onAlarm

looks good; r=dmose.  Sorry for the delay.
Attachment #220860 - Flags: first-review?(dmose) → first-review+
patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: