Closed
Bug 335315
Opened 18 years ago
Closed 18 years ago
Null pointer dereference in [@ _newJSDContext]
Categories
(Other Applications Graveyard :: Venkman JS Debugger, defect)
Other Applications Graveyard
Venkman JS Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kherron+mozilla, Assigned: rflint)
References
()
Details
(Keywords: coverity)
Attachments
(1 file)
813 bytes,
patch
|
rginda
:
review+
brendan
:
superreview+
|
Details | Diff | Splinter Review |
This was found through a coverity scan of the firefox source. Please refer to the sample URL. At line 99, |_newJSDContext| calls |calloc| to allocate a structure, storing the pointer in |jsdc|. If the allocation fails, execution jumps to |label_newJSDContext_failure| at line 154. Following this label are calls to |jsd_DestroyObjectManager| and |jsd_DestroyAtomTable|, both of which dereference |jsdc| without any null check.
Assignee | ||
Comment 1•18 years ago
|
||
Comment 2•18 years ago
|
||
Comment on attachment 219729 [details] [diff] [review] Check if jsdc is null first r=rginda
Attachment #219729 -
Flags: review?(rginda) → review+
Assignee | ||
Updated•18 years ago
|
Whiteboard: [checkin needed]
Comment 3•18 years ago
|
||
Doesn't this need SR?
Assignee | ||
Updated•18 years ago
|
Attachment #219729 -
Flags: superreview?(brendan)
Assignee | ||
Updated•18 years ago
|
Whiteboard: [checkin needed]
Comment 4•18 years ago
|
||
Comment on attachment 219729 [details] [diff] [review] Check if jsdc is null first Sure. Hey Rob, do you still want to require sr for jsd changes? Many other modules have dropped sr requirements in light of stronger peering and ownership. /be
Attachment #219729 -
Flags: superreview?(brendan) → superreview+
Assignee | ||
Updated•18 years ago
|
Whiteboard: [checkin needed]
Comment on attachment 219729 [details] [diff] [review] Check if jsdc is null first grumble, i have all sorts of changes including this one floating around. i'm going to twiddle a flag or two just so that i can remember to do this checkin this weekend
Attachment #219729 -
Flags: review?
Attachment #219729 -
Flags: review?
Summary: Null pointer dereference in _newJSDContext (js/jsd/jsd_high.c) → Null pointer dereference in [@ _newJSDContext]
Whiteboard: [checkin needed]
Assignee | ||
Comment 6•18 years ago
|
||
Checked in by timeless on 05/11/06 -> rev 3.13
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•