335637 - "Backup" and "Backup all" should be "Back Up" in the Certificate action menu

Status: RESOLVED FIXED

(Camino Graveyard :: Security, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

From bug 335393:

Someone can file yet another bug about changing "Backup" to "Back Up"

This looks like just a nib change to CertificatesWindow.nib

Comment 1

[Mike Pinkerton (not reading bugmail)]

http://dictionary.reference.com/search?q=backup

i don't think we need to change this. To me "Back Up" means to go backwards, like reverse.

Comment 2

[Chris Lawson (gone)]

Keep scrolling on that page, Mike, and you'll see this:

backup

<operating system> ("back up" when used as a verb)

Two words as a verb. None of the definitions above that are for verbs; they're all for nouns or adjectives. You can have "backup software" to make a "backup", but that software "backs up" your data. (Note you don't say it "backups" your data.)

cl

Comment 3

[Mike Pinkerton (not reading bugmail)]

you win ;) i concede.

Comment 4

[Chris Stewart]

Is this being worked on?  I'm new to contributing and something this minor would be a good place to start.  Can I run with this if it hasn't been assigned?

- Chris

Comment 5

[Chris Lawson (gone)]

(In reply to comment #4)
> Is this being worked on?  I'm new to contributing and something this minor
> would be a good place to start.  Can I run with this if it hasn't been
> assigned?

Go right ahead, and welcome to the gang!

cl

Comment 6

[Chris Stewart]

Thank you.  It will take me some time to get my environment configured, etc, etc, so please be patient with me. :)

- chris

Comment 7

[Isriya Paireepairit]

Attachment: change "Backup" to "Back Up" in .nib file

Comment 8

[froodian (Ian Leue)]

Comment on attachment 227873 [details] [diff] [review]
change "Backup" to "Back Up" in .nib file

I'm glad you're interested in helping out, but we don't accept diffs for nib files.  For more info, check out http://wiki.caminobrowser.org/Development:Reviewing (you want to zip the actual nib and attach it here) :)

Comment 9

[Isriya Paireepairit]

Attachment: Reupload CertificatesWindow.nib

Ok, I don't know about this before. Reupload.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Håkan, are we doing the right thing tab-chain wise in this nib (Security prefPane, Certificates button)?  

Seems to me this is just like the Bookmarks Manager, so the views should be getting a focus ring (which would lessen confusion as to why tabbing once--with a Category that has some right-pane content--doesn't focus the first item but requires a down-arrow--again, just like the BM).

Comment 11

[Håkan Waara]

This nib worked fine for me, focus-wise. The first listbox is focused (with a blue focus ring), and the listboxes (+  the action button with FKA on) are in the focus chain.

Comment 12

[froodian (Ian Leue)]

Comment on attachment 227881 [details]
Reupload CertificatesWindow.nib

Hi Isriya,

This looks good, but it occurs to me that while we're touching this nib, we should make the window comply with our margins standards in http://wiki.caminobrowser.org/Development:Editing_Nibs

Specifically, the action menu button should be 17 px below the view it's under, and the bottom of the window should  be 20 px below that.  Also, the initialFirstResponder should be set to the entire extended split view, and the extended split view and the action menu should each have a nextKeyView of eachother.

Comment 13

[Isriya Paireepairit]

Actually, I didn't touch anything in the NIB, just change the string and recompile. mmm... I might accidentially hit it and move. 

Anyway, I'll resubmit this. Thanks for review.

Comment 14

[Isriya Paireepairit]

Attachment: Reupload CertificatesWindow.nib again

Update NIB file to match Camino Development Guideline.

Comment 15

[froodian (Ian Leue)]

Comment on attachment 229613 [details]
Reupload CertificatesWindow.nib again

In this case I would leave initialFirstResponder unset (since that way it does the Right Thing in focusing Category first, instead of focusing the actions menu button).

Also, the actions menu button should only be 17 px below the bottom of of the ExtendedOutlineView (Name, details, expires, etc).

Looking better.

Comment 16

[froodian (Ian Leue)]

Attachment: New CertificatesWindow.nib

Comment 17

[froodian (Ian Leue)]

Attachment: New CertificatesWindow.nib

Increases min width and does a 3px bounding-box adjustment, per IRC.

Comment 18

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 247247 [details]
New CertificatesWindow.nib

Nice; r=ardissone

Requesting rs on these cosmetic nib-only changes (per policy).

Comment 19

[Stuart Morgan]

Comment on attachment 247247 [details]
New CertificatesWindow.nib

(In reply to comment #12)
> Specifically, the action menu button should be 17 px below the view it's under,
> and the bottom of the window should  be 20 px below that.

No; this creates a lot of weird dead space at the bottom, and every example of similar controls I can think of looks the way it was before.

Comment 20

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #19)
> (From update of attachment 247247 [details] [edit])
> (In reply to comment #12)
> > Specifically, the action menu button should be 17 px below the view it's under,
> > and the bottom of the window should  be 20 px below that.
> 
> No; this creates a lot of weird dead space at the bottom, and every example of
> similar controls I can think of looks the way it was before.

I see nothing in the HIG that supports having a miniscule bottom margin instead of the standard Aqua margins; moreover, it looks out of place in comparison with our cookie sheets, where the button is well-placed.

Comment 21

[Stuart Morgan]

(In reply to comment #20)
> I see nothing in the HIG that supports having a miniscule bottom margin instead
> of the standard Aqua margins;

The 'G' is for Guidelines; I don't think we should slavishly following margin guidelines that are there solely for aesthetics even when it makes the overall visual appearance worse and more unbalanced.

Note that we also use the current cert spacing in the Bookmark Manager.

> moreover, it looks out of place in comparison with our cookie sheets, where the
> button is well-placed.

We also have an aqua button there, making the space much less empty. If the cert viewer were a sheet with a Done button, then I would agree.

Comment 22

[froodian (Ian Leue)]

What about putting the button back close to the table view, but leaving the 20 px between it and the edge of the window?  Although the bookmark manager has dimensions that reflect our currect certificate window, the status bar buffers the edge of the window.  I really think that the 20px around the edge is important.

Comment 23

[froodian (Ian Leue)]

Attachment: New CertificatesWindow.nib

Does comment 22

Comment 24

[froodian (Ian Leue)]

Attachment: Actually 20 px

Sorry, *this* does comment 22

Comment 25

[froodian (Ian Leue)]

Attachment: Screenshot of 247613

Comment 26

[Stuart Morgan]

Comment on attachment 247613 [details]
Actually 20 px

sr=smorgan

Comment 27

[froodian (Ian Leue)]

Checked in on 1.8branch and trunk.