Closed
Bug 335911
Opened 18 years ago
Closed 18 years ago
Change nsIContent::IsContentOfType to nsINode::IsNodeOfType
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
VERIFIED
FIXED
People
(Reporter: sicking, Assigned: sicking)
References
Details
Attachments
(2 files)
245.13 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
921 bytes,
text/plain
|
Details |
I have a patch that moves the IsContentOfType function to nsINode (and renames it appropriately). Most of othe patch is just s/IsContentOfType/IsNodeOfType/ s/IsNodeOfType\(nsIContent::/IsNodeOfType\(nsINode::/ The interesting bits are the implementations of IsNodeOfType and the changes to nsINode.h and nsIContent.h
Assignee | ||
Comment 1•18 years ago
|
||
This should take care of it. Most of the patch is just search-n-replace, the interesting parts is in nsINode.h, nsIContent.h and the IsNodeOfType implementations.
Attachment #220618 -
Flags: superreview?(bzbarsky)
Attachment #220618 -
Flags: review?(bzbarsky)
Comment 2•18 years ago
|
||
Comment on attachment 220618 [details] [diff] [review] Patch to fix >Index: accessible/src/base/nsAccessible.cpp > nsIContent *nsAccessible::GetLabelContent(nsIContent >+ return aForNode->IsNodeOfType(nsINode::eXUL) ? GetXULLabelContent(aForNode) : > GetHTMLLabelContent(aForNode); Fix the indent? >Index: gfx/src/x11shared/nsFT2FontCatalog.cpp I be thinkin' de changez to dis file be a mistake, yes? Make sure not to land these! The rest looks good. r+sr=bzbarsky; I want this in so I can use it in some places in classinfo!
Attachment #220618 -
Flags: superreview?(bzbarsky)
Attachment #220618 -
Flags: superreview+
Attachment #220618 -
Flags: review?(bzbarsky)
Attachment #220618 -
Flags: review+
Assignee | ||
Comment 3•18 years ago
|
||
Checked in. Dunno what the change to nsFT2FontCatalog.cpp came from.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 4•18 years ago
|
||
Do we need to change the comment here?
Assignee | ||
Comment 5•18 years ago
|
||
Yeah, or just nuke it. Mind if I just do that in a later patch?
Comment 6•18 years ago
|
||
(In reply to comment #5) > Yeah, or just nuke it. Mind if I just do that in a later patch? That's fine.:)
Comment 7•14 years ago
|
||
V. based on code inspection.
Assignee: general → jonas
Status: RESOLVED → VERIFIED
QA Contact: ian → general
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•