335982 - Default theme left behind in Sunbird's profile directory

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

Since the makefile changes from bug 286034 never landed for Sunbird there are now profiles with default theme in their extensions directory for toolkit version 1.8. This caused havoc for Firefox and I think we should just check on all upgrades for the existence of the default theme in the profile's extensions directory instead of only on upgrade from the 1.7 toolkit version.

Comment 1

[Robert Strong (they/them - no direct email)]

This depends on bug 335753 since that bug will handle the makefile changes for Sunbird which are required in order for this bug to provide any value

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch

Benjamin, if you approve this I promise I won't land it until after bug 335753 lands. I also added a check to see if all add-ons have appManaged="true" so we won't open the compatibility checker when it isn't necessary.

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch

Turns out earlier versions of Sunbird used a different GUID.

Once again, if you approve this I promise I won't land it until after bug 335753 lands. I also added a check to see if all add-ons have appManaged="true" so we won't open the compatibility checker when it isn't necessary.

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 220296 [details] [diff] [review]
patch

Obsoleting... this handles upgrading from Sunbird 0.2 but not from 0.3... fun :(

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 220296 [details] [diff] [review]
patch

bah... nevermind. The reason it didn't fix the 0.3 upgrade is due to it returning early in checkForMismatches since it wasn't a version upgrade. So this does work when there is a version upgrade.

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 220296 [details] [diff] [review]
patch

This doesn't do the right thing when going from 0.3a1 to 0.3a2. The joys of when not all toolkit apps get updated for changes

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: patch (more one-off fun - a.k.a. sometimes a sledgehammer is the right tool for the job)

Comment 8

[Robert Strong (they/them - no direct email)]

Attachment: patch (w/ new and improved comments)

Benjamin, this will make any profile with a default theme in it remove the toolkit 1.8 extensions datasource to avoid trying to install and uninstall the default theme during the same pass which is a use case that has never been supported or for that matter needed. I also heavily commented it since why this needs to be done is to say the least confusing... hopefully one day these one-offs can be removed.

Comment 9

[Robert Strong (they/them - no direct email)]

Fixed on trunk

Comment 10

[Robert Strong (they/them - no direct email)]

Verbal a+ from bsmedberg... checked in to MOZILLA_1_8_BRANCH