Closed Bug 336004 Opened 18 years ago Closed 18 years ago

Coverity 456, resource leak

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect)

Product:
Core Graveyard
Component:
Installer: XPInstall Engine
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jonsmirl, Unassigned)

Details

(Keywords: coverity, memory-leak)

Attachments

(1 file, 1 obsolete file)

Change check to !buffer
692 bytes, patch
benjamin
: review+
Details | Diff | Splinter Review 
Fix error condition memory leak in char* nsRegisterItem::toString()
Attached patch Reorder things to remove leak (obsolete) — — Splinter Review 

    
  

        Attachment #220303 -
        Flags: review?(benjamin)

    
    

    
  
Comment on attachment 220303 [details] [diff] [review]
Reorder things to remove leak

style nit, could you make the second check (!buffer) instead of (buffer == nsnull), it's more idiomatic.

        Attachment #220303 -
        Flags: review?(benjamin) → review-

    
    

    
  


  

        Attachment #220303 -
        Attachment is obsolete: true

        Attachment #222177 -
        Flags: review?(benjamin)

    
  

        Attachment #222177 -
        Flags: review?(benjamin) → review+

    
    

    
  
Fixed on trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
  
Keywords: mlk
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: