336314 - Make storage threadsafe

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Brett Wilson]

Comment 1

[Brett Wilson]

Attachment: Patch

Comment 2

[Darin Fisher]

Comment on attachment 220672 [details] [diff] [review]
Patch

Looks fine.  My only comment is that it might make sense to document the initialization requirements of the mozStorageService implementation of mozIStorageService separately from the interface.  Interfaces could be re-used in general, so documentation about a particular ContractID is better placed next to the declaration of the ContractID ;-)

r=darin

Comment 3

[Brett Wilson]

On branch and trunk.

Comment 4

[Doug Shelton]

as expected, this change breaks BeOS builds due to lack of pthreads support in BeOS and lack of bthreads support in sqlite.  Bezilla team has filed a bug with sqlite to document this lack.

Is it possible to disable "Places" until this problem is resolved?  --disable-places no longer seems to work.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Places is disabled by default, but mozStorage is a core part of the platform.  The best thing to do would be to simply implement the bthreads threading backend for sqlite.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

(the sqlite bug in question seems to be http://www.sqlite.org/cvstrac/tktview?tn=1791)

Comment 7

[Doug Shelton]

(In reply to comment #5)
> Places is disabled by default, but mozStorage is a core part of the platform. 
> The best thing to do would be to simply implement the bthreads threading
> backend for sqlite.
> 
Because BeOS uses its own native threads (not pthreads), this is not really a workable solution.  Instead, we're going to need to implement bthreads under sqlite but this isn't quite so simple a task.

It would be great to find some other workaround in the meantime and any ideas would be appreciated.