Closed
Bug 336453
Opened 18 years ago
Closed 12 years ago
Autocomplete.css padding is incorrect
Categories
(Toolkit :: Themes, defect)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
People
(Reporter: mkaply, Unassigned)
References
Details
(Whiteboard: fixed by bug 462663)
Attachments
(1 file, 3 obsolete files)
455 bytes,
application/vnd.mozilla.xul+xml
|
Details |
Currently autocomplete.css includes a class "padded" specifically for an autocomplete widget to use if it doesn't have an image. However, the padding in the padded class does not match a normal textbox - it is still too small.
Reporter | ||
Comment 1•18 years ago
|
||
Updated•18 years ago
|
Component: General → XUL Widgets
Product: Firefox → Toolkit
QA Contact: general → xul.widgets
Reporter | ||
Comment 2•18 years ago
|
||
Reporter | ||
Comment 3•18 years ago
|
||
I got the padding wrong.
Attachment #231602 -
Attachment is obsolete: true
Reporter | ||
Updated•12 years ago
|
Attachment #231619 -
Flags: review?(gavin.sharp)
Reporter | ||
Comment 4•12 years ago
|
||
I retested on a current build using XUL Manager to show the testcase. Screenshot attached as well to show the problem.
Updated•12 years ago
|
Attachment #231619 -
Flags: review?(gavin.sharp) → review?(dao)
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Component: XUL Widgets → Themes
Depends on: 462663
QA Contact: xul.widgets → themes
Resolution: --- → FIXED
Whiteboard: fixed by bug 462663
Updated•12 years ago
|
Attachment #231619 -
Attachment is obsolete: true
Attachment #231619 -
Flags: review?(dao)
Reporter | ||
Comment 5•12 years ago
|
||
I just ran this on last night's nightly and it still has the same problem. The testcase shows this. This is on Windows 7
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Updated•12 years ago
|
Whiteboard: fixed by bug 462663
Reporter | ||
Updated•12 years ago
|
Attachment #231619 -
Attachment is obsolete: false
Comment 6•12 years ago
|
||
Comment on attachment 231619 [details] [diff] [review] Better fix This patch is ancient and doesn't apply at all. Also, it's unclear what problem attachment 587410 [details] shows.
Attachment #231619 -
Attachment is obsolete: true
Reporter | ||
Comment 7•12 years ago
|
||
If you load the testcase (at least on Windows), you'll see that the top text field is not as tall as the other text fields. Exactly what the screenshot shows.
Comment 8•12 years ago
|
||
The top text field is expected to be smaller, since it doesn't use the 'padded' class. See also comment 0...
Reporter | ||
Comment 9•12 years ago
|
||
6 years ago is a long time to remember why I opened this. So then the better question is why does an autocomplete textbox require the padded class in order to be the same size as a regular textbox? Shouldn't these two textboxes be the same size? <textbox flex="1" type="autocomplete"/> <textbox flex="1"/>
Comment 10•12 years ago
|
||
See comment 0 again: 'autocomplete.css includes a class "padded" specifically for an autocomplete widget to use if it doesn't have an image.' In other words, without padded, you're supposed to add an icon.
Reporter | ||
Comment 11•12 years ago
|
||
> In other words, without padded, you're supposed to add an icon.
But why?
I wonder how I figured that out six years ago. It's not documented anywhere.
I'll give up now.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Whiteboard: fixed by bug 462663
Updated•12 years ago
|
Attachment #587410 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•